Fix PHP 7 compatibility when attaching observer type of FOFUtilsObservableEvent #10742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please stick to what Nic is doing in FOF please :) From the issue you linked to Nic put the end() function higher up in the function (akeeba/fof@121eff4) |
|
I have changed it to match akeeba/fof@121eff4 |
|
Merged :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix PHP 7 compatibility when attaching observer type of FOFUtilsObservableEvent
Read this issue akeeba/fof#593
and this commit 791f561
Testing Instructions
Just review the code. When you will attach more then one observer type of FOFUtilsObservableEvent with the same event name (e.g. onAfterGetItem) then only the first observer will be fired twice.