New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tinyMCE modal close bug (again) #11048
Conversation
I have tested this item ✅ successfully on 262a4ae Also tested bootstrap modals (associations) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048. |
This should be in J3.6.0 ! |
I have tested this item ✅ successfully on 262a4ae This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048. |
RTC. Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048. |
I have tested this item ✅ successfully on 262a4ae This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048. |
Manually added rtc label |
Thank you @dgt41 and testers! |
Thanks for the info. I've tried to apply directly, but i don't find the exact node or place in the code to aply that. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11048. |
You are looking at the wrong place, this was a fix for J3.6.0, the fix for J3.6.1 is here: |
Pull Request for Issue #11047.
Testing Instructions
Follow these steps before and after applying this patch:
Add this snippet to administrator/components/com_content/models/forms/article.xml:
In administrator/components/com_content/views/article/tmpl/edit.php render the new field:
Go to any media form field (the "Images and links" tab works for this), select an image, and try to close the modal in any available manner (the insert/cancel buttons, the X icon, or clicking outside the modal).
Expected result
The modal is closed.
Actual result
The modal does not close. In the browser console is a "Uncaught RangeError: Maximum call stack size exceeded" message.
Note:
The problem is the way the scripts added to the document and consequently executed. Ideal solution will be to load and execute the overrides for jModalClose and SqueezeBox.close last but that is impossible with current Joomla API, therefore the ugly code in the behaviour.php.