-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator cache with 1 click #11286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
Fix#11195. com_cache. Button Delete All. Delte Site AND Administrator Cache with 1 click
Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator Cache with 1 click
Jul 24, 2016
ghost
mentioned this pull request
Jul 24, 2016
ghost
changed the title
Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator Cache with 1 click
Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator cache with 1 click
Jul 24, 2016
I have tested this item ✅ successfully on 890747e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286. |
@@ -165,15 +165,20 @@ public function getData() | |||
* | |||
* @return object | |||
*/ | |||
public function getCache() | |||
public function getCache($client_id = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add this new param to doc block
I have tested this item ✅ successfully on 890747e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286. |
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
…r cache with 1 click (joomla#11286) * deleteAll > getCache by client_id * deleteAll (cache): Delete Site AND Admin
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
…r cache with 1 click (joomla#11286) * deleteAll > getCache by client_id * deleteAll (cache): Delete Site AND Admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11195
Summary of Changes
Testing Instructions
If you have the possibility to use cache handlers other than File then please testtesttest, too. Thx!
EDIT: Be aware that if you use Cache Handler
Cache_Lite
that folders (column "Cache Groups") are not removed but only cache files in it that were created by Cache_Lite! You always will see a "1" in column "Number of Files" after deleting. That's a remaining fileindex.html
in each folder. That's not related to this PR.Apply patch.