Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator cache with 1 click #11286

Merged
merged 2 commits into from Aug 13, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2016

Pull Request for Issue #11195

"... usability issue that on an update of joomla we tell people to update the cache and right now they are a) mistakenly only cleaning the cache for the site not the admin and b) have to do three extra clicks when it just isnt needed."

Summary of Changes

  • Button Delete All (caches) deletes cache of Site and Administrator indepentend of Filter client_id.

Testing Instructions

If you have the possibility to use cache handlers other than File then please testtesttest, too. Thx!

EDIT: Be aware that if you use Cache Handler Cache_Lite that folders (column "Cache Groups") are not removed but only cache files in it that were created by Cache_Lite! You always will see a "1" in column "Number of Files" after deleting. That's a remaining file index.html in each folder. That's not related to this PR.

  • administrator/index.php?option=com_config
  • - Activate Cache with Cache Handler File
  • - Load some pages in FE and some in BE.
  • administrator/index.php?option=com_cache
  • - Via FTP create a folder /administrator/cache/Unbenannt/ (must be writeable/deleteable for Joomla)
  • - See entries with Filter set to Site
  • - See entries with Filter set to Administrator
  • Change Filter to Site
  • Click on button Delete All
  • Change Filter to Administrator
  • You'll see that all folders are still present including folder /Unbenannt/

Apply patch.

  • Follow the steps above.
  • You'll see that also Administrator folder /Unbenannt/ has been deleted. (Other folders were newly created immediately after they have been deleted.)
  • To see error messages:
  • - Via FTP create a folder /administrator/cache/Unbenannt/ (must be writeable/deleteable for Joomla)
  • - Via FTP create a folder /cache/Unbenannt/ (must be writeable/deleteable for Joomla)
  • - Via FTP create a folder /administrator/cache/Unbenannt1/ (must NOT be writeable/deleteable for Joomla)
  • - Via FTP create a folder /cache/Unbenannt1/ (must NOT be writeable/deleteable for Joomla)
  • Click on Delete All

24-07-_2016_16-34-16


24-07-_2016_16-34-36


24-07-_2016_16-35-30


24-07-_2016_16-35-01


@ghost ghost changed the title Fix#11195. com_cache. Button Delete All. Delte Site AND Administrator Cache with 1 click Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator Cache with 1 click Jul 24, 2016
@ghost ghost mentioned this pull request Jul 24, 2016
@ghost ghost changed the title Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator Cache with 1 click Fix#11195. com_cache. Button Delete All. Delete Site AND Administrator cache with 1 click Jul 24, 2016
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 890747e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286.

@@ -165,15 +165,20 @@ public function getData()
*
* @return object
*/
public function getCache()
public function getCache($client_id = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add this new param to doc block

@truptikagathara
Copy link

I have tested this item ✅ successfully on 890747e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11286.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 29, 2016
@wilsonge wilsonge merged commit cfe560a into joomla:staging Aug 13, 2016
@wilsonge wilsonge added this to the Joomla 3.6.3 milestone Aug 13, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
…r cache with 1 click (joomla#11286)

* deleteAll > getCache by client_id

* deleteAll (cache): Delete Site AND Admin
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
…r cache with 1 click (joomla#11286)

* deleteAll > getCache by client_id

* deleteAll (cache): Delete Site AND Admin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants