Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com_contact] Make ACL core.edit.own work (PR for 11466) #11503

Merged
merged 2 commits into from
Aug 15, 2016
Merged

[com_contact] Make ACL core.edit.own work (PR for 11466) #11503

merged 2 commits into from
Aug 15, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Aug 7, 2016 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #11466 (com_contact part).

Summary of Changes

The ACL core.edit.own is not working in com_contact.
This PR makes it work.

Testing Instructions

  1. Use latest staging
  2. Besides the Super User, create a user "test" added to "Administrator" group
  3. Go to com_contact Options, Permissions tab and diable "Edit" for "Administrator" group
  4. Now create a new contact with the "test" user (use another browser or a private window)
  5. Try to edit that item. You can't edit our own. Bug
  6. Now do the same test but with a contact category Permission. You can't edit our own. Bug
  7. Apply patch, repeat step 5. and 6. and now you can edit our own items.
  8. Code review

Also use the two users to do a general test with the com_contact edit permissions to confirm all is fine.

Documentation Changes Required

None.

Notes

This problem was discovered in GsoC 2016 Multilingual project.

This is very similiar with #11502.

This was referenced Aug 7, 2016
Merged
Closed
Merged
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 3282bfd

:1:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.

@infograf768
Copy link
Member

Note: The PR works great.
One issue, not related to this PR:
If the user is denied access to com_users Access Administration Interface (Typical for the default Manager group) then he can't assign a user to the Contact.
Needs some thought imho.

@alikon
Copy link
Contributor

alikon commented Aug 7, 2016

I have tested this item ✅ successfully on 3282bfd

works as described

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.

@infograf768
Copy link
Member

I have tested this item 🔴 unsuccessfully on 3282bfd

Changed my testing as we have a NOtice

[07-Aug-2016 07:10:36 UTC] PHP Notice: Undefined variable: record in ROOT/administrator/components/com_contact/controllers/contact.php on line 82

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.

@andrepereiradasilva
Copy link
Contributor Author

sorry guys. corrected that. please test.

@alikon
Copy link
Contributor

alikon commented Aug 7, 2016

no more notice after last update

@alikon
Copy link
Contributor

alikon commented Aug 7, 2016

I have tested this item ✅ successfully on a1fb945

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on a1fb945

RTC. Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.

@infograf768
Copy link
Member

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2016
@brianteeman
Copy link
Contributor

@wilsonge is this ok to merge or does it bring back a certain issue

@ggppdk ggppdk mentioned this pull request Aug 10, 2016
Merged
@andrepereiradasilva andrepereiradasilva mentioned this pull request Aug 12, 2016
Closed
@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Aug 14, 2016
@rdeutz
Copy link
Contributor

rdeutz commented Aug 14, 2016

this looks good to me @wilsonge, have set the milestone, your turn to press the merge button

@wilsonge
Copy link
Contributor

I'm just going to hold on this until i can test some stuff ;)

@andrepereiradasilva
Copy link
Contributor Author

ok @wilsonge, go ahead, more tests are alwys good.

Just informing that are (at least) 4 PR similiar to this one:

So if you find something all need to be changed.

@wilsonge wilsonge merged commit 3f2f1eb into joomla:staging Aug 15, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2016
@wilsonge
Copy link
Contributor

Oh didn't realise we'd merged the other two. Merging this then. We can go back

@andrepereiradasilva andrepereiradasilva deleted the acl-contact branch August 15, 2016 12:48
izharaazmi added a commit to izharaazmi/joomla-cms that referenced this pull request Aug 15, 2016
@izharaazmi
Merge branch 're-arrayhelper-min' into re-arrayhelper-minOLD
376f090 
* re-arrayhelper-min: (2467 commits)
  Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
  remove platform include (joomla#11615)
  [GitHub Templates] Make headings bigger (joomla#11607)
  [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503)
  Small review on docs & code structure in JModelLegacy library classes (joomla#11057)
  Obviously, this should be an array. (joomla#11610)
  Don't manually import JPlatform anymore (joomla#10841)
  Parse preprocess rules from component routers (joomla#8986)
  Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606)
  Add missing clean line after joomla#9277 (joomla#11605)
  Deprecate the _PROFILER global var (joomla#10845)
  Spelling errors (joomla#11604)
  Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603)
  Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511)
  [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593)
  [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502)
  $result-variable-undefined-given-default-value (joomla#9277)
  com_banners use exceptions. and not allowed is a 403 (joomla#11418)
  Frontend & plugins using the autoloader (joomla#10882)
  New version of PR 6788 (JText::_() Optimizations) (joomla#11235)
  ...
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
@andrepereiradasilva @ggppdk
[com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503)
81ed36c 
* fix core.edit.own

* correct variable
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
@andrepereiradasilva @roland-d
[com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503)
f553a2b 
* fix core.edit.own

* correct variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 3.6.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andrepereiradasilva @infograf768 @alikon @brianteeman @rdeutz @wilsonge @joomla-cms-bot