Remove 2 lines of commented code in the updater library

[zero-24]

Summary of Changes

This PR just removes two lines of commented code

Testing Instructions

This just remove 2 comments so i don't see how this can be tested ;)

Documentation Changes Required

None 😄

[jeckodevelopment]

I have tested this item ✅ successfully on a429f4d

On code review.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11520.}

[grhcj]

I have tested this item ✅ successfully on a429f4d

On Review

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11520.}

[brianteeman]

Are you sure about this. Has the todo ben done

On 8 August 2016 at 19:59, Lukas Mentel notifications@github.com wrote:

I have tested this item ✅ successfully on a429f4d
a429f4d

On Review

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11520
https://issues.joomla.org/tracker/joomla-cms/11520.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11520 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YpEwlBE9dMxxlAoFXFxZ2aZho_Mks5qd3yvgaJpZM4JfUfi
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[zero-24]

@todo remove code ?

[zero-24]

-       // @todo remove code: if(!isset($this->$tag->_data)) $this->$tag->_data = '';
-       // @todo remove code: $this->$tag->_data .= $data;

[brianteeman]

I am asking if the to-do has been done. Has the code been removed. Otherwise it makes no sense that the comment was put there

[zero-24]

The todo was to remove the commented code ;)

    /**
     * Character Parser Function
     *
     * @param   object  $parser  Parser object.
     * @param   object  $data    The data.
     *
     * @return  void
     *
     * @note    This is public because its called externally.
     * @since   11.1
     */
    public function _characterData($parser, $data)
    {
        $tag = $this->_getLastTag();
        // @todo remove code: if(!isset($this->$tag->_data)) $this->$tag->_data = '';
        // @todo remove code: $this->$tag->_data .= $data;
        // Throw the data for this item together
        $tag = strtolower($tag);
        if ($tag == 'tag')
        {
            $this->currentUpdate->stability = $this->stabilityTagToInteger((string) $data);
            return;
        }
        if (isset($this->currentUpdate->$tag))
        {
            $this->currentUpdate->$tag->_data .= $data;
        }
    }

There is no code like that in that method (expected the comment itself)

[brianteeman]

Strange it wasn't removed at the time then.

[zero-24]

Yes 😄

[wilsonge]

Those lines were done in a platform update in 2012. I'm pretty confident we'd have found any issues in the last 4 years if there were any :P