Postinstall for the case that the Update Cache time is eq 0 #11631

zero-24 · 2016-08-16T16:23:45Z

Pull Request for Issue #9789

Summary of Changes

This PR implemts a postinstall message that inform the users that they will never get mails with that setting

Testing Instructions

go to com_postinstall
hide all messages
check you com_installer config that the cache timout is != 0
please make sure the update mail plugin is enabled
apply this patch
go to you database and fire the SQL command in the update file with you database prefix.
go to com_postinstall
see no messages
go to the com_instaler settings again and set the cache timout to 0
got to com_postinstall
see the message (please double check typos and suggest changes to the strings!)
hit the action button
see the message is gone.
got to com_installer options again
see the cache timout is 6 now
set it back to 0
disable the update mail plugin
go to com_installer
check that the message is not there

Documentation Changes Required

None

brianteeman · 2016-08-16T16:26:58Z

administrator/language/en-GB/en-GB.plg_system_updatenotification.ini

+PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_DESC="If you choose Auto (default), the update notification email to Super Users will be in the site language at the time the plugin is triggered. By selecting a language here you are forcing the update notification emails to be sent in this specific language."
+PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_NONE="Auto"
+PLG_SYSTEM_UPDATENOTIFICATION_POSTINSTALL_UPDATECACHETIME="The Joomla! Update Notification will not run in that configuration"
+PLG_SYSTEM_UPDATENOTIFICATION_POSTINSTALL_UPDATECACHETIME_BODY="In your Installer Configuration you have set the Option Update Cache (in Hours) to 0 this means that Joomla is not caching the Update, but this also means that the plugin would need to send a mail on every page visit which is not implemented. Please change the value of the configuration to something higher than 0 (6 is default) or confirm that the Joomla! Update Notification will never send you mails."


this isnt correct. If you set it to 0 then you will get an email every time. Thats what the user reported

or did you just disable that?

hmm atleast @bertmert reported he get no mail.

We wondered that we didn't get any email concerning update 3.5.0=>3.5.1 from plugin updatenotification.php (until today). Several sites and providers.

#9789 (comment)

And for the code this condition https://github.com/joomla/joomla-cms/blob/staging/plugins/system/updatenotification/updatenotification.php#L51 can never be true if you have cache time eq 0 or do i miss something?

oops no - my memory failed me.

the string needs simplifying a bit. will do that tomorrow

Great. Thanks!

See #11575 for not receiving notification. Would be surprised if anyone receives notification. That means anyone without problems in their installation.

that don't work as yo never go to this point. you got ruled out here. https://github.com/joomla/joomla-cms/pull/11575/files#diff-389d7f2bc20fb10dd7192b69423c7ba6R51

i have commented there why you fix can't work 😄 and i don't think we should allow mails per site call.

My fix does work! Took me two days to debug it. Without the fix it bails out because the #_updates and xml both find 3.6.2 and because the condition is GT.
It is not about cache_timeout = 0, it is about 1 to 6.

Lets please move this to the another issue i have explained there. Thanks

brianteeman · 2016-08-16T16:38:56Z

administrator/language/en-GB/en-GB.plg_system_updatenotification.ini

+PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_LBL="Email Language"
+PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_DESC="If you choose Auto (default), the update notification email to Super Users will be in the site language at the time the plugin is triggered. By selecting a language here you are forcing the update notification emails to be sent in this specific language."
+PLG_SYSTEM_UPDATENOTIFICATION_LANGUAGE_OVERRIDE_NONE="Auto"
+PLG_SYSTEM_UPDATENOTIFICATION_POSTINSTALL_UPDATECACHETIME="The Joomla! Update Notification will not run in that configuration"


this not that

sovainfo · 2016-08-16T17:17:05Z

installation/sql/mysql/joomla.sql

@@ -1516,6 +1516,7 @@ INSERT INTO `#__postinstall_messages` (`extension_id`, `title_key`, `description
 (700, 'COM_CPANEL_WELCOME_BEGINNERS_TITLE', 'COM_CPANEL_WELCOME_BEGINNERS_MESSAGE', '', 'com_cpanel', 1, 'message', '', '', '', '', '3.2.0', 1),
 (700, 'COM_CPANEL_MSG_STATS_COLLECTION_TITLE', 'COM_CPANEL_MSG_STATS_COLLECTION_BODY', '', 'com_cpanel', 1, 'message', '', '', 'admin://components/com_admin/postinstall/statscollection.php', 'admin_postinstall_statscollection_condition', '3.5.0', 1),
 (700, 'PLG_SYSTEM_UPDATENOTIFICATION_POSTINSTALL_UPDATECACHETIME', 'PLG_SYSTEM_UPDATENOTIFICATION_POSTINSTALL_UPDATECACHETIME_BODY', 'PLG_SYSTEM_UPDATENOTIFICATION_POSTINSTALL_UPDATECACHETIME_ACTION', 'plg_twofactorauth_totp', 1, 'action', 'site://plugins/system/updatenotification/postinstall/updatecachetime.php', 'updatecachetime_postinstall_action', 'site://plugins/system/updatenotification/postinstall/updatecachetime.php', 'updatecachetime_postinstall_condition', '3.6.3', 1);


Sure about 'plg_twofactorauth_totp' ?

ahh copy and paste issue. Thanks fixed

conconnl · 2016-08-16T19:39:30Z

I have tested this item ✅ successfully on 66b9c23

Patch tested on MySQL

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11631.}

widmann-it · 2016-08-20T10:44:05Z

I have tested this item ✅ successfully on f33653b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11631.}

zero-24 · 2016-08-20T10:44:59Z

Thanks for testing RTC.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11631.}

zero-24 · 2016-08-20T14:08:12Z

Thnaks.

@brianteeman

…1631) * postinstall for the updatenotification plugin * postinstall for the updatenotification plugin * great autoloader 😄 * denglisch => en-GB * en-GB fix * en-GB again thanks @brianteeman * install sql * install sql missing spaces * c&p error thanks @sovainfo

zero-24 added 3 commits August 16, 2016 18:08

postinstall for the updatenotification plugin

932fe98

postinstall for the updatenotification plugin

51161f4

great autoloader 😄

eed2cb6

joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 16, 2016

zero-24 mentioned this pull request Aug 16, 2016

No updatenotification mail with cachetimeout = 0 #9789

Closed

brianteeman reviewed Aug 16, 2016
View reviewed changes

denglisch => en-GB

ad27df4

brianteeman reviewed Aug 16, 2016
View reviewed changes

zero-24 added 4 commits August 16, 2016 18:45

en-GB fix

485c86d

en-GB again thanks @brianteeman

72b4c87

install sql

8270ed8

install sql missing spaces

107b999

sovainfo reviewed Aug 16, 2016
View reviewed changes

c&p error thanks @sovainfo

66b9c23

zero-24 added 2 commits August 16, 2016 23:24

Merge branch 'staging' into postinstall_updateplugin

09f23f0

Merge branch 'staging' into postinstall_updateplugin

f33653b

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2016

brianteeman added this to the Joomla 3.6.3 milestone Aug 20, 2016

rdeutz merged commit 36c37ea into joomla:staging Aug 20, 2016

zero-24 deleted the postinstall_updateplugin branch August 20, 2016 14:08

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 20, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Postinstall for the case that the Update Cache time is eq 0 #11631

Postinstall for the case that the Update Cache time is eq 0 #11631

zero-24 commented Aug 16, 2016 •

edited

brianteeman Aug 16, 2016

brianteeman Aug 16, 2016

zero-24 Aug 16, 2016

brianteeman Aug 16, 2016

zero-24 Aug 16, 2016

sovainfo Aug 16, 2016

zero-24 Aug 16, 2016

zero-24 Aug 16, 2016

sovainfo Aug 16, 2016 •

edited

zero-24 Aug 16, 2016

brianteeman Aug 16, 2016

zero-24 Aug 16, 2016

sovainfo Aug 16, 2016

zero-24 Aug 16, 2016

conconnl commented Aug 16, 2016

widmann-it commented Aug 20, 2016

zero-24 commented Aug 20, 2016

zero-24 commented Aug 20, 2016

Postinstall for the case that the Update Cache time is eq 0 #11631

Postinstall for the case that the Update Cache time is eq 0 #11631

Conversation

zero-24 commented Aug 16, 2016 • edited

Summary of Changes

Testing Instructions

Documentation Changes Required

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sovainfo Aug 16, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conconnl commented Aug 16, 2016

widmann-it commented Aug 20, 2016

zero-24 commented Aug 20, 2016

zero-24 commented Aug 20, 2016

zero-24 commented Aug 16, 2016 •

edited

sovainfo Aug 16, 2016 •

edited