Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in content_type in getItemTags of com_users profile view #11681

Closed
wants to merge 2 commits into from
Closed

Fix typo in content_type in getItemTags of com_users profile view #11681

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2016

Pull Request for part 1 of Issue #11666

Summary of Changes (New)

(See comments #11681 (comment) and #11681 (comment))

After some investigations I removed these lines completely:

  • The line never worked correctly. No issues were reported for years. It always returns an empty array.
  • Tags are not fully implemented for com_users component yet. Just rudimentary. (And by the way my opinion is that it never should get implemented when I have a look on field #__content_types : field_mappings.). Thus this line never returns any meaningful datas.

Summary of Changes (Old/Outdated)

Correct typo in getItemTags() call. The first parameter is type_alias of DB table #__content_types.

20-08-_2016_05-00-12

Testing Instructions

Code review.
Tags are not implemented in user views at the moment (which is part 2 of issue #11666) .
Check if anything weird happens in user profile view in front-end after patch.

B\C ?

I don't see any issues for a line that is seneseless.

@andrepereiradasilva
Copy link
Contributor

andrepereiradasilva commented Aug 21, 2016

@ghost
Copy link
Author

ghost commented Aug 22, 2016

@andrepereiradasilva Thank you.
Hm, strange. There it's wrong (returns an empty array), too, but the article edit form works fine without this line concerning tags.
I have to make some investigations where when why we need getItemTags() at all in edit views.

@ghost
Copy link
Author

ghost commented Aug 22, 2016

Sorry! After some hours of investigations I'm closing this PR because the more I try to understand the logic of com_tags the less I understand...

@ghost ghost closed this Aug 22, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants