Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include autoloaded files in tests #11693

Merged
merged 1 commit into from Aug 20, 2016
Merged

Don't include autoloaded files in tests #11693

merged 1 commit into from Aug 20, 2016

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Aug 20, 2016

Summary of Changes

The test environment boots up the autoloader, so there is no need to include autoloaded files in the test classes. Remove extraneous include/require statements.

Testing Instructions

Unit tests pass, merge this.

Documentation Changes Required

N/A

@rdeutz
Copy link
Contributor

rdeutz commented Aug 20, 2016

I have tested this item ✅ successfully on 79e6359


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11693.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 79e6359

united tests passed.
"merge this" 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11693.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 79e6359


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11693.

@dgrammatiko
Copy link
Contributor

RTC @rdeutz go on and hit that button

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2016
@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Aug 20, 2016
@rdeutz rdeutz merged commit 326e3a3 into joomla:staging Aug 20, 2016
@mbabker mbabker deleted the Less-Require-In-Tests branch August 20, 2016 20:09
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label Aug 22, 2016
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
two successful tests besides my test so merging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants