-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Using modal_category field in various core locations #11717
Conversation
I have tested this item ✅ successfully on 1183afc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717. |
@@ -118,6 +118,11 @@ protected function getInput() | |||
{ | |||
$linkCategories .= '&forcedLanguage=' . $this->element['language']; | |||
$linkCategory .= '&forcedLanguage=' . $this->element['language']; | |||
$modalTitle = JText::_('COM_CATEGORIES_CHANGE_CATEGORY') . ' (' . $this->element['label'] . ')'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we will have issues in RTL languages here?
besides the comment above all seems to work fine |
I have tested this item ✅ successfully on 1183afc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717. |
Same comment as in the other PR regarding the use of the brackets This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717. |
@infograf768 same here. Remove brackets and it goes to RTC |
I have tested this item ✅ successfully on 80741f5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11717. |
Thank you @infograf768 On 22 August 2016 at 14:44, infograf768 notifications@github.com wrote:
Brian Teeman |
I agree with the 3.7.0 milestone setting, this here is changing the UI/UX the other PRs are only changing text. |
In this case, I am ready to modify this PR and only change the modal title without touching at the xmls for now. |
@infograf768 sounds good |
Took off the changes in the modal and will make a new PR with these only in order to get the modal title change in 3.6.3. |
Please confirm PR #11751 |
Merged with ef98d6b - thanks JM! |
This PR lets use the existing modal_category field when possible in core, which is quite handy when one has many categories to deal with:
Menu items:
List Contacts in a Category
Content Category blog
Content Category list
List Newsfeeds in a category
Also:
User Notes
mod_articles categories
Example:
It also adds in multilingual associations the forcedlanguage in the title of the
Select or Change Category
modal.Example, from the already existing:
we get when using the Select button:
This can go in 3.6.3 as it is not a new feature (contrary to #11694 which depends on the new modal_menu fields already merged in 3.7.0).