New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the accessibility of the sidebar menu in ISIS #11723

Merged

wilsonge merged 9 commits into joomla:staging from brianteeman:a11ymenu

Aug 22, 2016

Contributor

brianteeman commented Aug 22, 2016 •

edited by joomla-cms-bot

Summary of Changes

The light grey highlight when hovering or navigating with the keyboard through the sidebar menu is almost impossible to see.

This PR uses the exact same highlighting as the dropdown menu

Before

After

brianteeman added 9 commits

August 14, 2016 16:27


          toolbar

8f995f1


          Revert "toolbar"

97d1fb7

This reverts commit 8f995f1.


          Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

2baa00b

…taging


          Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

14f5b1c

…taging


          Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

962b424

…taging


          Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

24e6c45

…taging


          Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

b5ffa27

…taging


          Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

4ddd833

…taging


          a11y sidebar menu

106dbc3

joomla-cms-bot added the PR-staging label

Member

C-Lodder commented Aug 22, 2016

I have tested this item ✅ successfully on 106dbc3

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11723.}

2 similar comments

ghost commented Aug 22, 2016

I have tested this item ✅ successfully on 106dbc3

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11723.}

MATsxm commented Aug 22, 2016

I have tested this item ✅ successfully on 106dbc3

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11723.}

MATsxm commented Aug 22, 2016

thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11723.}

Contributor

zero-24 commented Aug 22, 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11723.}

joomla-cms-bot added the RTC label

Member

jeckodevelopment commented Aug 22, 2016

I have tested this item ✅ successfully on 106dbc3

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11723.}

wilsonge merged commit 81db367 into joomla:staging

wilsonge added this to the Joomla 3.6.3 milestone

joomla-cms-bot removed the RTC label

Contributor Author

brianteeman commented Aug 22, 2016

Thanks

brianteeman deleted the a11ymenu branch

August 22, 2016 12:20

rdeutz pushed a commit that referenced this pull request


          Improve the accessibility of the top menu in ISIS #11723 (#11724)

5cabd9b

* toolbar

* Revert "toolbar"

This reverts commit 8f995f1.

* a11y top menu improvement

* remove hover

* Revert "remove hover"

This reverts commit fc9f6eb.

* Revert "a11y top menu improvement"

This reverts commit ce67c94.

* redo a11y fix for focus on nabber

brianteeman mentioned this pull request

Sidebar navigation hover width #11973

Merged

roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request


          Improve the accessibility of the sidebar menu in ISIS (joomla#11723)

e539807

* toolbar

* Revert "toolbar"

This reverts commit 8f995f1.

* a11y sidebar menu

roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request


          Improve the accessibility of the top menu in ISIS joomla#11723 (jooml…

cfdcddc

…a#11724)

* toolbar

* Revert "toolbar"

This reverts commit 8f995f1.

* a11y top menu improvement

* remove hover

* Revert "remove hover"

This reverts commit fc9f6eb.

* Revert "a11y top menu improvement"

This reverts commit ce67c94.

* redo a11y fix for focus on nabber

This was referenced Nov 15, 2016

[j3.7] a11y Regression outline on toolbar fix #12896

Closed

a11y regression fix outline on toolbar fix #12935

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment