Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Media field lightbox in subform #11760

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Fix Media field lightbox in subform #11760

merged 1 commit into from
Aug 24, 2016

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Aug 23, 2016

Pull Request for Issue #11755

Summary of Changes

This PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.

Testing Instructions

Create ../modules/mod_login/text.xml to which add the following...

<?xml version="1.0" encoding="UTF-8"?>
<form>
    <fieldset name="images" class="image-subform">
        <field name="image" type="media" default="" label="Label1"  description="Desc1" size="30" />
        <field name="text" type="textarea" filter="raw" rows="10" cols="42" default="" label="Label2" description="Desc2" />
    </fieldset>
</form>

Add the following to the mod_login.xml file:

<field name="subformtest" type="subform" formsource="modules/mod_login/text.xml" class="advancedSelect" min="1" max="50" multiple="true" layout="joomla.form.field.subform.repeatable" groupByFieldset="true" label="Image(s)" description="Add image(s) to display in gallery" />

Then in the Module Manager, open the Login module. Add a number of subforms extending the page height. Click 'Select' in the last subform.

Before patch

screen1

After Patch

screen2

This PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.
@C-Lodder
Copy link
Member

C-Lodder commented Aug 23, 2016

Can't find this on JIssues, so marking this test as successful here

@zero-24
Copy link
Contributor

zero-24 commented Aug 23, 2016

Just reported it to jissues @C-Lodder joomla/jissues#871

@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 8843ffd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11760.

@zero-24
Copy link
Contributor

zero-24 commented Aug 23, 2016

@C-Lodder i have just added you test


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11760.

@zero-24
Copy link
Contributor

zero-24 commented Aug 23, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11760.

@jeckodevelopment jeckodevelopment added PR-staging RTC This Pull Request is Ready To Commit labels Aug 23, 2016
@jeckodevelopment
Copy link
Member

bot is sleeping!

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

No it's not. We're fighting with ModSecurity yet again.

@jeckodevelopment jeckodevelopment added this to the Joomla 3.6.3 milestone Aug 23, 2016
@wilsonge wilsonge merged commit 21e1223 into joomla:staging Aug 24, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 24, 2016
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
This PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants