Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beez3 template breaks parameter injection pulling params from JFactory #11825

Merged
merged 1 commit into from Aug 29, 2016
Merged

Beez3 template breaks parameter injection pulling params from JFactory #11825

merged 1 commit into from Aug 29, 2016

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Aug 28, 2016

Summary of Changes

When the application renders the template, it injects the template parameters into the JDocument instance. However, only JDocumentHtml actually stores a parameters reference. Since our templates are in scope of JDocument (aside from the error.php layout all of them are in scope of JDocumentHtml), the template should reference the injected parameters instead of issuing another call to JFactory to fetch the data. By doing so, this breaks parameter injection by not using the injected data.

Testing Instructions

The Beez3 template should continue to work with its configured parameters.

Documentation Changes Required

It should be made clear what data is made available when a template file is included in the scope of JDocumentHtml and the examples updated to support this practice.

@bhavikpatel10
Copy link

@bhavikpatel10
Copy link

I have tested this item ✅ successfully on f5201fb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11825.

@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Aug 29, 2016
@RonakParmar
Copy link

I have tested this item ✅ successfully on f5201fb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11825.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11825.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 29, 2016
@rdeutz rdeutz merged commit eddff74 into joomla:staging Aug 29, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2016
@mbabker mbabker deleted the param-use branch August 29, 2016 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants