Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap javascript components initiator #11922

Closed
wants to merge 21 commits into from
Closed

Bootstrap javascript components initiator #11922

wants to merge 21 commits into from

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Sep 4, 2016

Pull Request for Issue #11654

Summary of Changes

  • No more inline scipts for bootstrap components
  • Make Joomla's bootstrap (js) dependancy less strict, as the init script together with the jlayouts dictate the js framework. For example someone can override bootstrap.js, bootstrap-init.js and the layouts and use Foundation or Ukit or any other framework!

Testing Instructions

You will Need to use 3.7 branch for testing!!!

For modals, tooltips, popover and tabs apply this patch and navigate to isis template on the backend. Ensure that no javascript errors are logged and everything still works.
To test the other bootstrap components download this module https://github.com/dgt41/bootstrap-test/raw/gh-pages/bootstrap_test.zip install, publish in the front end and then visit that page (template must be protostar).
Enjoy!

B/C

There are few layouts that are touched, but joomla's b/c promise states that these are not B/C breaks. Down to PLT for a decision on that.

Documentation Changes Required

None.


This change is Reviewable

@brianteeman
Copy link
Contributor

If you are removing a file please add it to the list in script.php

@brianteeman brianteeman closed this Sep 4, 2016
@brianteeman brianteeman reopened this Sep 4, 2016
@dgrammatiko
Copy link
Contributor Author

@brianteeman done, thanks!

@andrepereiradasilva
Copy link
Contributor

this seems to work fine.

side note: have the other tabs issue (Permissions Tab selected) (#11648) but not related to this PR.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Oct 6, 2016
@zero-24
Copy link
Contributor

zero-24 commented Oct 8, 2016

I have notices that in the backend the Edit Tooltips (e.g. com_content) don't work anymore as bs tooltips there are just browser tooltips.

Also I'm not sure if this is a bug here or in the mod if i show it in the frontend it looks like this:
image

See the kitten on the debug console. Also the page is jumping.

What is Affix supposed to do?

image

@dgrammatiko dgrammatiko changed the title Rebase #11654 for 3.7 Bootstrap javascript components initiator Oct 12, 2016
@dgrammatiko
Copy link
Contributor Author

@zero-24 try to use the module in an article with {loadmodule...} or {loadposition...}. This module wasn't created or tested for narrow positions (left, right etc), so that might be a problem.
Affix just sticks the image to a given value (in px) so when you scroll the image should remain in the same position

@zero-24
Copy link
Contributor

zero-24 commented Oct 16, 2016

I have tested this item ✅ successfully on cbcb940

👍 Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922.

@rdeutz rdeutz changed the base branch from 3.7.x to staging October 25, 2016 17:58
@hans2103
Copy link
Contributor

hans2103 commented Nov 4, 2016

I have tested this item ✅ successfully on cbcb940


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922.

@dgrammatiko
Copy link
Contributor Author

Conflicts resolved

@roland-d
Copy link
Contributor

roland-d commented Nov 4, 2016

@zero-24 and @hans2103 Can you test once more? Thanks.

@hans2103
Copy link
Contributor

hans2103 commented Nov 4, 2016

I have tested this item ✅ successfully on 9e0f4bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922.

}

/** Modals **/
if (modal) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is always will be true as on top you use modal = $('.joomla-modal'),
jQuery always return "jQuery object" even if .joomla-modal do not exist on the page,

maybe you meant if(modal.length)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, I though modal = Joomla.getOptions('bootstrap.modal') which of course is not the case....

@roland-d
Copy link
Contributor

roland-d commented Nov 5, 2016

@dgt41 I am afraid there is a new conflict.

@dgrammatiko
Copy link
Contributor Author

@roland-d and fixed

@zero-24
Copy link
Contributor

zero-24 commented Nov 14, 2016

@dgt41 did you want to close this? So this should be removed from the mileston too?

@zero-24 zero-24 removed this from the Joomla 3.7.0 milestone Nov 14, 2016
@dgrammatiko
Copy link
Contributor Author

dgrammatiko commented Nov 14, 2016

First of all a big thank you to all the people spend some time with this PR.
An now the explanation why I closed it:
My main idea here was

  • remove the inline script
  • get the code ready for some Joomla.ui API that would freed joomla from any javascript framework.

I am sorry that I have wasted people's precious time here 😕

@zero-24
Copy link
Contributor

zero-24 commented Nov 14, 2016

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants