New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap javascript components initiator #11922
Conversation
If you are removing a file please add it to the list in script.php |
@brianteeman done, thanks! |
this seems to work fine. side note: have the other tabs issue (Permissions Tab selected) (#11648) but not related to this PR. |
@zero-24 try to use the module in an article with {loadmodule...} or {loadposition...}. This module wasn't created or tested for narrow positions (left, right etc), so that might be a problem. |
I have tested this item ✅ successfully on cbcb940 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922. |
I have tested this item ✅ successfully on cbcb940 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922. |
Conflicts resolved |
I have tested this item ✅ successfully on 9e0f4bd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11922. |
} | ||
|
||
/** Modals **/ | ||
if (modal) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is always will be true
as on top you use modal = $('.joomla-modal')
,
jQuery always return "jQuery object" even if .joomla-modal
do not exist on the page,
maybe you meant if(modal.length)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, I though modal = Joomla.getOptions('bootstrap.modal')
which of course is not the case....
@dgt41 I am afraid there is a new conflict. |
@roland-d and fixed |
@dgt41 did you want to close this? So this should be removed from the mileston too? |
First of all a big thank you to all the people spend some time with this PR.
I am sorry that I have wasted people's precious time here 😕 |
Thanks 👍 |
Pull Request for Issue #11654
Summary of Changes
Testing Instructions
You will Need to use 3.7 branch for testing!!!
For modals, tooltips, popover and tabs apply this patch and navigate to isis template on the backend. Ensure that no javascript errors are logged and everything still works.
To test the other bootstrap components download this module https://github.com/dgt41/bootstrap-test/raw/gh-pages/bootstrap_test.zip install, publish in the front end and then visit that page (template must be protostar).
Enjoy!
B/C
There are few layouts that are touched, but joomla's b/c promise states that these are not B/C breaks. Down to PLT for a decision on that.
Documentation Changes Required
None.
This change is