Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code style fixed for administrator\components\com_content #11989

Merged
merged 2 commits into from
Sep 8, 2016

Conversation

photodude
Copy link
Contributor

@photodude photodude commented Sep 8, 2016

Pull Request for Code Style Issues .

Summary of Changes

  • Please consider an empty line before the if statement
  • No blank line found after control structure
  • Blank line found at start of control structure
  • Expected 1 newline after opening brace; 2 found
  • Expected 0 spaces before closing bracket; 1 found
  • Please consider an empty line before the return statement
  • Object operator not indented correctly
  • Expected "boolean" but found "bool" for function return type
  • Line exceeds 150 characters

Automatically fixed with PHPCS2 fixers

Testing Instructions

Merge by Code review

Documentation Changes Required

none

- Please consider an empty line before the if statement
- No blank line found after control structure
- Blank line found at start of control structure
- Expected 1 newline after opening brace; 2 found
- Closing parenthesis of a multi-line IF statement must be on a new line
- Expected 0 spaces before closing bracket; 1 found
- Please consider an empty line before the return statement
- Object operator not indented correctly
- Expected "boolean" but found "bool" for function return type
- Line exceeds 150 characters
Automatic fixes
- Multi-line function call not indented correctly;
- Closing parenthesis of a multi-line function call must be on a line by
itself

manual fix
- Closing parenthesis of a multi-line IF statement must be on the same
line
@zero-24
Copy link
Contributor

zero-24 commented Sep 8, 2016

RTC on review thanks 👍


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11989.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 8, 2016
@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Sep 8, 2016
@rdeutz rdeutz merged commit cb67505 into joomla:staging Sep 8, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 8, 2016
@photodude photodude deleted the PHPCS-fix8 branch September 8, 2016 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants