Remove deprecated code for administrator #12278
Conversation
|
Please add the SQL Update files to remove the module |
|
@zero-24 you mean com_admin/sql ? |
|
Yes :) |
|
As well as the normal install sql under installation/sql |
|
@zero-24 ok, done. Travis happy (at least not complaining about these changes) |
|
@dgt41 i mean the extension ;) As you removed the mod_submenu extension we need to run on update a delete on the extension table and in the install sql we need to remove that extension too :) |
|
👍 |
Documentation Changes RequiredRemoved extension & removed methods |
| @@ -0,0 +1,3 @@ | |||
| DELETE FROM `#__assets` WHERE `id` = 47; | |||
There was a problem hiding this comment.
This needs to be removed from the update SQL. We cannot guarantee asset ID 47 is this module.
There was a problem hiding this comment.
Do we purge the assets structure anymore?
There was a problem hiding this comment.
AFAIK we don't have any updates that touch the assets table with direct SQL (aside from schema changes). It's too risky making changes to its contents for a wide variety of reasons, which is in part why there's that method in the update script to check the base assets for new components are added.
| @@ -0,0 +1,3 @@ | |||
| DELETE FROM `#__assets` WHERE `id` = 47; | |||
|
|
|||
| DELETE FROM `#__extensions` WHERE `name` = ''mod_submenu''; | |||
There was a problem hiding this comment.
The quoting on this line is busted.
There was a problem hiding this comment.
There was a problem hiding this comment.
hmm this looks not merged see: https://github.com/joomla/joomla-cms/pull/12281/files
There was a problem hiding this comment.
I only fixed the quoting with 2bc5a9a - not the other part :)
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Admin should still work
Documentation Changes Required