JFormOption #12453
JFormOption #12453
Conversation
|
I'll look at some of these failing tests soon and also add some new tests but this latest commit actually puts this feature to use in many of the standard forms. You can now test the usability by using any of these modified forms (for example, the Global Configuration form). |
|
This should fix the failing tests but now it looks like I need to rebase. |
okonomiyaki3000
force-pushed
the
JFormOption
branch
from
8fd06e6
to
5fd040b
Compare
|
this should fix those conflicts but I had some errors and failures in the tests. only in tests that had nothing at all to do with this PR though. So whatever that means... |
|
OK, there was one legit error there that was probably mine. Let's see if it works now. |
…dList so that there is only one implementation of getOptions(). New class JFormOption and assorted option-type classes to be used to generate lists of options based on the <option/> xml element. Other related changes to JForm and JFormHelper.
okonomiyaki3000
force-pushed
the
JFormOption
branch
from
12bf803
to
fd722d0
Compare
|
@okonomiyaki3000 Do you want to resolve the merge conflicts or close this? |
|
I hope we can get this one in J4, the code so much better than the current codebase |
|
Hmm. I still want to do this but I think it might be easier to start a new branch instead of trying to rebase this one. |
|
@okonomiyaki3000 Should we tag this for Joomla 4? |
|
I just need to redo the whole thing for Joomla 4. |
Pull Request for Issue # .
Summary of Changes
This is a revival of #5147 which was really just a continuation of #1192 so please see those for historical discussions.
The basic idea here is to eliminate the need for the many different field types that generate specific kinds of lists while, at the same time, making list, checkboxes, and radiobutton types more flexible and consistent. This is done with the concept of option types. So that now the the
<option>tag can take atypeattribute (and probably other attributes as needed) which will determine which options are to appear in theselect,radio,checkboxor other form control.Testing Instructions
Create a form with fields using the
list,radio, orcheckboxestype and assign it options of one or more of the option types....OK, that's a big hassle. I think what this pr really needs is for these option types to actually be used in the places where they can be used. That is coming soon.
Documentation Changes Required
Certainly.