Removing unnecessary code from com_search router

[Hackwar]

The code that is being removed does nothing. Literally. It acts on an empty array... I was thinking about removing much of the code in parse(), too, but while Joomla itself does not create such URLs, you could hand in the searchword as a first segment and that worked in the past, so we will have to keep that in until at least 4.0...

[brianteeman]

Looks like this was introduce by @wilsonge here #3399

[SamuelSchepp]

I have tested this item ✅ successfully on 6531a19

Removed code does nothing, since $segments is always array().
Searching by SEF URL index.php/search/my%20word/ still works.
@icampus

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12482.}

[eXsiLe95]

I have tested this item ✅ successfully on 6531a19

Tested

Search

1. Go to /index.php/search
2. Search for some content
3. Go to /index.php/search/<some%20content> (which is a SEF URL)
4. Activate bugfix
5. Go to /index.php/search
6. Search for some content
7. Go to /index.php/search/<some%20content> (which is a SEF URL)

Behaviour

Removed code does not change anything

Comparing the results of the test (step 1-3 and 5-7), there is no difference. The usual search as well as SEF URLs still work. The removed code does not affect anything since $segments is always an empty array.

Tested @icampus

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12482.}

[franz-wohlkoenig]

RTC after two successful tests.