Use the JHtml::_ function instead of calling functions directly. #12546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
suggested changes
Oct 25, 2016
mbabker
reviewed
Oct 25, 2016
libraries/cms/html/html.php
Outdated
| @@ -670,7 +670,7 @@ public static function stylesheet($file, $attribs = array(), $relative = false, | |||
| * | |||
| * @return mixed nothing if $path_only is false, null, path or array of path if specific js browser files were detected. | |||
| * | |||
| * @see JHtml::stylesheet() | |||
| * @see JHtml::_('stylesheet', ) | |||
There was a problem hiding this comment.
Can you revert this line too (and if there are any others in doc blocks, those as well)?
okonomiyaki3000
force-pushed
the
use-jhtml-underscore
branch
from
126d01d
to
3973dfb
Compare
|
@mbabker tests have been reverted, please check. |
mbabker
approved these changes
Nov 21, 2016
|
I have tested this item ✅ successfully on 3973dfb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12546. |
|
@okonomiyaki3000 can you update your PR, it's out of sync, Thanks |
okonomiyaki3000
force-pushed
the
use-jhtml-underscore
branch
from
3973dfb
to
de758c7
Compare
|
Should be in sync now. |
|
I have tested this item ✅ successfully on ae82474 On new installation PHP7.1.1 and Joomla! 3.7.0-beta2 dev [ Amani ] 2-February-2017 18:53 GMT:
|
|
I have just fixed the conflicts. -> RTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Instead of calling JHtml static functions directly, call them with the underscore function like
JHtml::_('functionname');so that it's possible to override them.Testing Instructions
The changed files could potentially affect many pages (for example, any list page with a disabled ordering column). You should see no difference before and after applying the patch.
Documentation Changes Required
No but, if there is some documentation for developers, it would be a good idea for that documentation to make it clear that
JHtmlstatic functions should not be called directly but invoked through the_function.