Allow multiple (different) editors in one page #12561
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /** | ||
| * @copyright Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
| (function() { | ||
| "use strict"; | ||
| /** | ||
| * Javascript to insert the link | ||
| * View element calls jSelectContact when a contact is clicked | ||
| * jSelectContact creates the link tag, sends it to the editor, | ||
| * and closes the select frame. | ||
| */ | ||
|
|
||
| window.jSelectContact = function(id, title, catid, object, link, lang) | ||
| { | ||
| var hreflang = '', tag, editor; | ||
|
|
||
| if (!Joomla.getOptions('xtd-contacts')) { | ||
| // Something went wrong! | ||
| window.parent.jModalClose(); | ||
| return false; | ||
| } | ||
|
|
||
| editor = Joomla.getOptions('xtd-contacts').editor; | ||
|
|
||
| if (lang !== '') { | ||
| hreflang = ' hreflang = "' + lang + '"'; | ||
| } | ||
|
|
||
| tag = '<a' + hreflang + ' href="' + link + '">' + title + '</a>'; | ||
|
There was a problem hiding this comment. Personally i would prefer when you do a document.createElement('a') here etc. then hardcoding a link into a string. There was a problem hiding this comment. Too fast, we do support IE8, so not possible There was a problem hiding this comment. Hm document.createElement should work in IE8? |
||
|
|
||
| /** Use the API, if editor supports it **/ | ||
| if (window.Joomla && window.Joomla.editors && Joomla.editors.instances && Joomla.editors.instances.hasOwnProperty(editor)) { | ||
| Joomla.editors.instances[editor].replaceSelection(tag) | ||
| } else { | ||
| window.parent.jInsertEditorText(tag, editor); | ||
| } | ||
|
|
||
| window.parent.jModalClose(); | ||
| }; | ||
|
|
||
| document.addEventListener('DOMContentLoaded', function(){ | ||
| // Get the elements | ||
| var elements = document.querySelectorAll('.select-link'); | ||
|
|
||
| for(var i = 0, l = elements.length; l>i; i++) { | ||
|
There was a problem hiding this comment. Just out of curiosity, why are you saving elements length in a variable? ;) cs btw. There was a problem hiding this comment. itar in phpstorm create those... |
||
| // Listen for click event | ||
| elements[i].addEventListener('click', function (event) { | ||
| event.preventDefault(); | ||
| var functionName = event.target.getAttribute('data-function'); | ||
|
|
||
| if (functionName === 'jSelectContact') { | ||
| // Used in xtd_contacts | ||
| window[functionName](event.target.getAttribute('data-id'), event.target.getAttribute('data-title'), null, null, event.target.getAttribute('data-uri'), event.target.getAttribute('data-language'), null); | ||
| } else { | ||
| // Used in com_menus | ||
| window.parent[functionName](event.target.getAttribute('data-id'), event.target.getAttribute('data-title'), null, null, event.target.getAttribute('data-uri'), event.target.getAttribute('data-language'), null); | ||
| } | ||
| }) | ||
| } | ||
| }); | ||
| })(); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /** | ||
| * @copyright Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
| (function() { | ||
| "use strict"; | ||
|
|
||
| window.insertPagebreak = function(editor) { | ||
| /** Get the pagebreak title **/ | ||
| var alt, tag, title = document.getElementById('title').value; | ||
|
|
||
| if (!window.parent.Joomla.getOptions('xtd-pagebreak')) { | ||
| // Something went wrong! | ||
| window.parent.jModalClose(); | ||
| return false; | ||
| } | ||
|
|
||
| /** Get the pagebreak toc alias -- not inserting for now **/ | ||
| /** don't know which attribute to use... **/ | ||
| alt = document.getElementById('alt').value; | ||
|
|
||
| title = (title != '') ? 'title="' + title + '"' : ''; | ||
| alt = (alt != '') ? 'alt="' + alt + '"' : ''; | ||
|
|
||
| tag = '<hr class="system-pagebreak" ' + title + ' ' + alt + '/>'; | ||
|
There was a problem hiding this comment. Same as above, wouldn't document.createElement be nicer? There was a problem hiding this comment. Hm it should work fine in IE8? Shouldn't it? We use document.createElement in a lot of other JS files There was a problem hiding this comment. Actually it shouldn't be any problem, just checked... There was a problem hiding this comment. @yvesh checking this again, I am not in favour as we are passing a string to the editor and I have no clue if all editors out there will be happy with an element instead of a string |
||
|
|
||
| /** Use the API, if editor supports it **/ | ||
| if (window.Joomla && window.Joomla.editors && Joomla.editors.instances && Joomla.editors.instances.hasOwnProperty(editor)) { | ||
| Joomla.editors.instances[editor].replaceSelection(tag) | ||
| } else { | ||
| window.parent.jInsertEditorText(tag, editor); | ||
| } | ||
|
|
||
| window.parent.jModalClose(); | ||
| return false; | ||
| }; | ||
| })(); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /** | ||
| * @copyright Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
|
|
||
| window.insertReadmore = function(editor) { | ||
| "use strict"; | ||
| if (!Joomla.getOptions('xtd-readmore')) { | ||
| // Something went wrong! | ||
| return false; | ||
| } | ||
|
|
||
| var options, content; | ||
|
|
||
| options = window.parent.Joomla.getOptions('xtd-readmore'); | ||
|
|
||
| content = (new Function('return ' + options.editor))(); | ||
|
|
||
| if (content.match(/<hr\s+id=("|')system-readmore("|')\s*\/*>/i)) { | ||
| alert(options.exists); | ||
|
There was a problem hiding this comment. it's what was there, what else can it be? There was a problem hiding this comment. I don't know why it is there any ways, but not a fan of alerts at all ;) Maybe use Joomla.renderMessages instead? There was a problem hiding this comment. I guess is the same story as the buttons of the toolbar, where also an alert is utilised... There was a problem hiding this comment. @yvesh This was a great idea generator, so J4 will come with some shiny new |
||
| return false; | ||
| } else { | ||
| /** Use the API, if editor supports it **/ | ||
| if (window.Joomla && window.Joomla.editors && Joomla.editors.instances && Joomla.editors.instances.hasOwnProperty(editor)) { | ||
| Joomla.editors.instances[editor].replaceSelection('<hr id="system-readmore" />') | ||
| } else { | ||
| window.parent.jInsertEditorText('<hr id="system-readmore" />', editor); | ||
| } | ||
| } | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it would be nice to have since tags in js too.. Any thoughts on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a way, have to do some testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yvesh so what is the
@sincesupposed to be for all these scripts, because ok now they are static files but the code comes from way back?