[com_menus] - wrong group by when multilanguages enabled - postgresql #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the code i dont see why this is just for postgresql Also your test instructions dont describe the issue so its hard to test |
|
if mysql was in sql strict mode See #12494 for more info |
conflict fix
|
test instructions updated, conflicts resolved |
|
@alikon still see conflicts! |
|
closing this one in favour of #12999 wich does'nt have conflicts hopefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for fix regression from #12051 .
Summary of Changes
fixed wrong
group bywhen multilanguages enabledTesting Instructions
latest staging fresh multilanguage install
Go to Menu -> All menu items
postgresql - got sql error wrong group by
mysql - should work as before