Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Include group state only when not on back end list #12696

Merged
merged 4 commits into from Dec 14, 2016

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Nov 2, 2016

Pull Request for Issue #12692.

Summary of Changes

Shows only fields in the form on the back end for published groups.

Testing Instructions

  • Create a Field Group for Articles.
  • Create a Field and assign it to that group
  • Unpublish the Field Group.

Expected result

The field should not be proposed in the edit form as its Group is unpublished.

Actual result

The field is still proposed under the tab of its Field Group when editing an article.

@laoneo laoneo changed the title Include group state only when not on back end list [com_fields] Include group state only when not on back end list Nov 2, 2016
@infograf768
Copy link
Member

Tested successfully (I had again problems with SHA @mbabker )

@brianteeman
Copy link
Contributor

@infograf768 - again - clear your browser cache

On 2 November 2016 at 16:37, infograf768 notifications@github.com wrote:

Tested successfully (I had again problems with SHA @mbabker
https://github.com/mbabker )


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12696 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZZWatY5hgeW0LJNZYwkSP9C11YKks5q6LxjgaJpZM4KnGQj
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

https://laoneo@github.com/Digital-Peak/joomla-cms.git into group-state

Conflicts:
	administrator/components/com_fields/models/fields.php
@Bakual
Copy link
Contributor

Bakual commented Dec 7, 2016

Can you maybe add a comment as to why we even have that check? Because it confused me as well.
Now I think it's just so we still see the fields in the fields manager, right?

@laoneo
Copy link
Member Author

laoneo commented Dec 7, 2016

Yes, it considers the group state only on the front. We never consider the group state on the back end for lists.

@Bakual
Copy link
Contributor

Bakual commented Dec 7, 2016

Agreed. Can you add a comment to it? Because I don't think we have that case anywhere else (usually we have different models in front- and backend).

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on c9b6f4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12696.

@laoneo
Copy link
Member Author

laoneo commented Dec 8, 2016

Comment added

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f4c413c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12696.

@laoneo
Copy link
Member Author

laoneo commented Dec 14, 2016

We have here two successful tests, can be set to RTC.

@Bakual
Copy link
Contributor

Bakual commented Dec 14, 2016

Lets just merge it instead :)

@Bakual Bakual merged commit bf6693b into joomla:staging Dec 14, 2016
@Bakual Bakual added this to the Joomla 3.7.0 milestone Dec 14, 2016
@laoneo laoneo deleted the group-state branch December 14, 2016 07:37
@laoneo
Copy link
Member Author

laoneo commented Dec 14, 2016

Even better. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants