New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_fields] Include group state only when not on back end list #12696
Conversation
Tested successfully (I had again problems with SHA @mbabker ) |
@infograf768 - again - clear your browser cache On 2 November 2016 at 16:37, infograf768 notifications@github.com wrote:
Brian Teeman |
https://laoneo@github.com/Digital-Peak/joomla-cms.git into group-state Conflicts: administrator/components/com_fields/models/fields.php
Can you maybe add a comment as to why we even have that check? Because it confused me as well. |
Yes, it considers the group state only on the front. We never consider the group state on the back end for lists. |
Agreed. Can you add a comment to it? Because I don't think we have that case anywhere else (usually we have different models in front- and backend). |
I have tested this item ✅ successfully on c9b6f4d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12696. |
Comment added |
I have tested this item ✅ successfully on f4c413c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12696. |
We have here two successful tests, can be set to RTC. |
Lets just merge it instead :) |
Even better. Thanks. |
Pull Request for Issue #12692.
Summary of Changes
Shows only fields in the form on the back end for published groups.
Testing Instructions
Expected result
The field should not be proposed in the edit form as its Group is unpublished.
Actual result
The field is still proposed under the tab of its Field Group when editing an article.