Skip to content

Set correct default values for user creation in the sample data - #13127

Merged
wilsonge merged 1 commit into
joomla:stagingfrom
AlexRed:patch-20
Dec 11, 2016
Merged

wilsonge merged 1 commit into
joomla:stagingfrom
AlexRed:patch-20

Conversation

@AlexRed

@AlexRed AlexRed commented Dec 8, 2016 •

Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Summary of Changes

https://github.com/joomla/joomla-cms/blob/3.6.4/administrator/components/com_users/config.xml#L45-L68
Default values should be send mail to admin and admin activation.
The default value for the useractivation param is 2

Testing Instructions

Install Joomla 3.7.0 and use the sample_learn.sql sample data,
confirm the "New User Account Activation" setting is Administrator

Documentation Changes Required

None.

@AlexRed

AlexRed commented Dec 8, 2016

Copy link
Copy Markdown
Contributor Author

same problem in the sample_testing.sql

@jeckodevelopment

Copy link
Copy Markdown
Member

if not already in place, these changes should be reflected also in PostgreSQL and SQL Azure data for each sample set.

@AlexRed

AlexRed commented Dec 8, 2016

Copy link
Copy Markdown
Contributor Author

PostgreSQL and SQL Azure data are already ok.

@infograf768

Copy link
Copy Markdown
Member

for useractivation, yep.
But you may want to look at guest_usergroup as they do not get the same id

@AlexRed

AlexRed commented Dec 9, 2016

Copy link
Copy Markdown
Contributor Author

form "guest_usergroup":"13" to "guest_usergroup":"9" ?

@infograf768

Copy link
Copy Markdown
Member

I guess we have to check what is the good one.

@AlexRed

AlexRed commented Dec 9, 2016 •

Copy link
Copy Markdown
Contributor Author

in the sample_learn.sql there are 2 new group: "Shop Suppliers (Example)" (ID 10) and "Customer Group (Example)" (ID 12)

and I think the developer set the last ID number for the guest_usergroup (13)

also in the joomla.sql guest_usergroup is the last number 9
maybe it's better to leave so

@zero-24

zero-24 commented Dec 9, 2016

Copy link
Copy Markdown
Contributor

In the sample learn data the guest group have id 13 so everything is correct we just need to correct the useractivation and set this to admin.

@infograf768

Copy link
Copy Markdown
Member

What is important is to make sure all sample data have the same settings.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Dec 10, 2016
@wilsonge
wilsonge merged commit ec08ae2 into joomla:staging Dec 11, 2016
wilsonge pushed a commit that referenced this pull request Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants