Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes in plugins #13213

Merged
merged 4 commits into from Dec 18, 2016
Merged

Various changes in plugins #13213

merged 4 commits into from Dec 18, 2016

Conversation

frankmayer
Copy link
Contributor

Summary of Changes

  • Removed one-time use variable
  • Merged unset calls
  • Removed obvious variants from ternary operation
  • Used short syntax for applied operation

This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for plugins, which is still on hold (#12228).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.

The changes in this PR are few and very easy to review. In hope that this will get merged quickly. ;)

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

@wilsonge wilsonge merged commit faced55 into joomla:staging Dec 18, 2016
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Dec 18, 2016
@frankmayer frankmayer deleted the various-changes-in-plugins branch December 25, 2016 21:48
@frankmayer frankmayer mentioned this pull request Jan 6, 2017
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants