-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable sql query cache in debug mode #13268
Disable sql query cache in debug mode #13268
Conversation
There is also option I do not know if anybody care but for mysql driver missing line: |
Yeah i noticed that too. Didn't add it because i have no MySQL drivers to test. If anyone confirms it works i can add it. |
IMHO It does not depend on type of driver like mysql or mysqli or pdomysql. |
ok added to mysql too, but his needs to be tested in mysql also |
I have tested this item ✅ successfully on eecd48e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13268. |
Profil comes with this message: "No SHOW PROFILE (maybe because there are more than 100 queries)" Does somebody know what´s going on here? |
|
@brianteeman Is there any rule? How to become a new owner? |
Fork the source branch of the PR, make your changes, and open a new PR. |
@csthomas will you be able to take over this? |
I created a new PR #20322. |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/13268 |
closed in favor of PR #20322 as stated above. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13268. |
Pull Request for Issue #13265.
Summary of Changes
This PR makes the query cache disabled when db driver runs in debug mode.
Only for mysql, because the profiling only seems to work there.
Also add checks for profiling in pdomysql (was missing), which meand pdo mysql driver now as the "Profile" in debug console too.
Testing Instructions
Example
With query cache
Without query cache
Documentation Changes Required
None.
Notes