Replace unnecessary double quotes in administrator #1 #13292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepereiradasilva
approved these changes
Dec 19, 2016
| @@ -87,7 +87,7 @@ protected static function getStemRules() | |||
| . chr(244) . chr(251) . chr(249) . chr(231); | |||
|
|
|||
| // The rule patterns include all accented words for french language | |||
| $vars['rule_pattern'] = "/^([a-z" . $vars['accents'] . "]*)(\*){0,1}(\d)([a-z" . $vars['accents'] . "]*)([.|>])/"; | |||
| $vars['rule_pattern'] = '/^([a-z' . $vars['accents'] . "]*)(\*){0,1}(\d)([a-z" . $vars['accents'] . ']*)([.|>])/'; | |||
There was a problem hiding this comment.
Why not the quotes in the Middle?
There was a problem hiding this comment.
Wasn't sure. Just checked again. Will change.
andrepereiradasilva
approved these changes
Dec 20, 2016
|
👍 |
frankmayer
deleted the
unnecessary-double-quotes-in-administrator-no-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The changes in this PR should be fairly easy to review. In hope that this will get merged quickly so further work can be done without conflicting with other PRs. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.