New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecate _QQ_ 2] Save language overrides with escaped double quotes #13427
Conversation
I have tested this item ✅ successfully on 56d1bc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13427. |
I have tested this item ✅ successfully on 56d1bc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13427. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13427. |
warning concerning strings that would be used through js. see my comment in the specific pr. |
In any case, can you explain the reason for using |
Is not related to this PR.
because the only thing to escape are the double quotes ( |
@rdeutz |
Summary of Changes
As discussed in #13421
This PR changes language overrides save to ini method so we use escaped double quotes (
\"
) instead of"_QQ_"
.Also adds a new method to save the language strings to a ini file so it can be easily used when needed.
Testing Instructions
"
). Save it, load it again and confirm if ok./administrator/language/overrides/en-GB.override.ini
. Example:A test with <a href=\"https://joomla.org\" target=\"_blank\">Joomla</a>
/administrator/language/overrides/en-GB.override.ini
with_QQ_
and escaped quotes. Example:Ex: add to template index.php
Documentation Changes Required
None.