Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests for $db->quoteName() #13860

Merged
merged 1 commit into from Feb 15, 2017
Merged

Add missing tests for $db->quoteName() #13860

merged 1 commit into from Feb 15, 2017

Conversation

csthomas
Copy link
Contributor

@csthomas csthomas commented Feb 2, 2017

Pull Request for previous PR #13825

Summary of Changes

Add missing tests.

Testing Instructions

Code review.

Documentation Changes Required

No

@csthomas
Copy link
Contributor Author

csthomas commented Feb 5, 2017

@PhilETaylor @wilsonge This is a missing unit test for new $db->quoteName().

photodude
photodude approved these changes Feb 14, 2017
View reviewed changes
Copy link
Contributor

@photodude photodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on code review and function source testing instructions

@wilsonge wilsonge merged commit f022ae3 into joomla:staging Feb 15, 2017
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Feb 15, 2017
@csthomas csthomas deleted the qn_tests branch February 17, 2017 13:20
@csthomas csthomas mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@photodude photodude photodude approved these changes

Assignees
No one assigned
Labels
Unit/System Tests
Projects
None yet
Milestone
Joomla 3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@csthomas @photodude @wilsonge @joomla-cms-bot