Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imp] Added a validation message for the URL field when schema is not provided #13885

Merged
merged 5 commits into from
Mar 1, 2017

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Feb 3, 2017

Pull Request for Issue #13870.

Summary of Changes

Added a validation message to the JFormRuleUrl class.

Testing Instructions

  1. Create a url field : fill schema and make sure it's not relative
  2. Create a new content and fill the url field with a domain name (example.com).

Expected result

A warning message displays "Invalid URL : URL schema is missing in example.com. Please add one of the following at the begining : http...." with no explanation.

Actual result

A warning message displays "Invalid field" with no explanation.

Documentation Changes Required

No.

@ghost
Copy link

ghost commented Feb 3, 2017

I have tested this item ✅ successfully on c0048b4

Lang-String missing:

screen shot 2017-02-03 at 9 40 39 am


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

@justinherrin
Copy link
Contributor

Just a minor spelling typo to correct...
"Invalid URL : URL schema is missing in %s. Please add one of the following at the begining : %s."

Should be...
"Invalid URL : URL schema is missing in %s. Please add one of the following at the beginning : %s."

@ghost
Copy link

ghost commented Feb 22, 2017

I have tested this item ✅ successfully on c1636c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

@infograf768
Copy link
Member

Please use ordered variables in the string
"Invalid URL : URL schema is missing in %1$s. Please add one of the following at the beginning : %2$s ."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 19a0e9f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

@marrouchi
Copy link
Contributor Author

RTC please

@infograf768
Copy link
Member

RTC as the change in the string concerns only the type of variable.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13885.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 1, 2017
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Mar 1, 2017
@wilsonge wilsonge merged commit cc97ed2 into joomla:staging Mar 1, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants