Create an Exception for a missing component #13919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The base
Exception
class really shouldn't be thrown, it's too generic and gets caught by too many try/catch blocks. Good practice is to use more specialized exceptions.In
JComponentHelper::renderComponent()
anException
is thrown if the component is missing (either the option parameter is empty, the component is disabled, or the entry point file doesn't exist in the filesystem). I've created a newJComponentExceptionMissing
class to represent this error state instead.Testing Instructions
A request for a non-existing or disabled component should result in a
JComponentExceptionMissing
object being thrown versus the base levelException
.Documentation Changes Required
N/A