Move JErrorPage to namespace #14231
Merged
Move JErrorPage to namespace #14231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know so far this has been just a straight "move to namespace" effort, but with this one class, can we take the opportunity to rename it to something more logical? It really isn't an error page renderer (even though that's what it is doing), it's the default global exception handler. |
|
That's the reason why I do a pr per folder that we can do some cleanup during the move. What about moving it to |
|
I don't care if it's in a subnamespace, I just prefer the class name to not be |
|
Done |
yvesh
approved these changes
Feb 24, 2017
laoneo
force-pushed
the
j3/namespace/error
branch
from
dd72e61
to
2b26c8a
Compare
laoneo
force-pushed
the
j3/namespace/error
branch
from
2b26c8a
to
1be6cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move JErrorPage class to namespace. Additionally some doc blocks are changed to be inline with rest.