Move JHelp to namespace #14232
Merged
Move JHelp to namespace #14232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's used in part with the help screen system. There are a couple calls to |
|
True, didn't search globally 🙈 |
yvesh
reviewed
Feb 24, 2017
| $lang = JFactory::getLanguage(); | ||
| $version = new JVersion; | ||
| $lang = \JFactory::getLanguage(); | ||
| $version = new \JVersion; |
There was a problem hiding this comment.
As you are going to namespace JVersion, JText etc. too, don't you want to start by namespacing the most used / important ones first and then use the namespaced version here ;)
Else you need to go again through each file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves JHelp to namespace. But honestly I couldn't find any reference to this class in the whole repo. So can it be deprecated?