Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Add support for max length for text and textarea #14458

Merged
merged 5 commits into from
Mar 30, 2017

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Mar 10, 2017

Pull Request for Issue #14374.

Summary of Changes

Adds the max length parameter to the text and textarea custom field. Additionally it fixes a bug in the maxlength parameter of the JLayout of the textarea field.

Testing Instructions

  • Create a text custom field for articles.
  • Set the max length parameter to 2.
  • Save an close the field.
  • Edit an article.

Expected result

It should not be possible to add more than 2 characters into the text field when editing the article.

Actual result

The max length parameter is not available as it is a new feature.

Documentation Changes Required

Adding the max length parameter description to the text and textarea field in the documentation pages.

@ghost
Copy link

ghost commented Mar 10, 2017

I have tested this item ✅ successfully on 4eccfc1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

@@ -8,5 +8,7 @@ PLG_FIELDS_TEXT_LABEL="Text (%s)"
PLG_FIELDS_TEXT_PARAMS_FILTER_LABEL="Filter"
PLG_FIELDS_TEXT_PARAMS_FILTER_DESC="Allow the system to save certain html tags or raw data."
PLG_FIELDS_TEXT_PARAMS_FILTER_RAW="Raw"
PLG_FIELDS_TEXT_PARAMS_MAXLENGTH_LABEL="Max Length"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maximum Length

This is more consistent with elsewhere

@@ -8,5 +8,7 @@ PLG_FIELDS_TEXT_LABEL="Text (%s)"
PLG_FIELDS_TEXT_PARAMS_FILTER_LABEL="Filter"
PLG_FIELDS_TEXT_PARAMS_FILTER_DESC="Allow the system to save certain html tags or raw data."
PLG_FIELDS_TEXT_PARAMS_FILTER_RAW="Raw"
PLG_FIELDS_TEXT_PARAMS_MAXLENGTH_LABEL="Max Length"
PLG_FIELDS_TEXT_PARAMS_MAXLENGTH_DESC="Limits the number of characters that may be entered."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maximum number of characters that can be entered.

This is more accurate and consistent with elsewhere

@laoneo
Copy link
Member Author

laoneo commented Mar 10, 2017

Changed. Perhaps somebody should change the docs as well https://docs.joomla.org/Text_form_field_type.

@coolcat-creations
Copy link
Contributor

I have tested this item ✅ successfully on d633af8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

1 similar comment
@ghost
Copy link

ghost commented Mar 17, 2017

I have tested this item ✅ successfully on d633af8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

@jeckodevelopment
Copy link
Member

@laoneo can you please look at the conflicts?

@laoneo
Copy link
Member Author

laoneo commented Mar 17, 2017

COnflicts solved.

@jeckodevelopment
Copy link
Member

@coolcat-creations and @franz-wohlkoenig can you please re-test?

@laoneo
Copy link
Member Author

laoneo commented Mar 20, 2017

Again conflicts solved, can we set this one to RTC?

@ghost
Copy link

ghost commented Mar 20, 2017

I have tested this item ✅ successfully on b1e8a04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on b1e8a04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

@ghost
Copy link

ghost commented Mar 25, 2017

RTC as there are 2 successfully Tests?

@laoneo
Copy link
Member Author

laoneo commented Mar 25, 2017

Just merged staging into this branch, can be set to RTC.

@normanmm
Copy link

I have tested this item ✅ successfully on aed12c4

After patch installation I can see a single query for all custom fields ( as opposed to a separate query for each custom field before the patch).
However ,I just want to point out ( though this is a different issue) that the fields are displayed quite messy and improperly , mostly in the front-end. This may have to do with me not knowing properly the management of custom fields...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

@normanmm
Copy link

Sorry , my mistake. My post was intended for #14558 .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

@laoneo
Copy link
Member Author

laoneo commented Mar 28, 2017

Can we set this one to RTC as well?

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14458.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2017
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Mar 28, 2017
@rdeutz rdeutz merged commit 5e50c3d into joomla:staging Mar 30, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 30, 2017
@laoneo laoneo deleted the cf/max-length branch March 31, 2017 05:41
infograf768 added a commit to infograf768/joomla-cms that referenced this pull request Mar 31, 2017
@infograf768
Copy link
Member

@laoneo

You have re-added obsolete language strings for both text an textarea plugins where we are now using Global strings
PR: #15017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants