-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding classes to pagebreak.php and other improvements #14670
Conversation
Also remove the next/prev link if on last/first page respectively. No reason to keep an unclickable link, might as well not show it at all.
@AndySDH do you have Test Instructions? Congrats to your first PR. |
Thanks! I don't have any specific test instructions as there are just display changes or underlying code changes, as in, there is not much to "test" :D |
Hello, what is the status of this small fix being added? Newer and newer Joomla updates keep coming out yet this keeps seeming to be left out, so I'm finding myself to always having to core-override it on each update. |
Nothing has happened because no one has tested it. |
I have tested this item 🔴 unsuccessfully on 320538e On first page: On last page: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14670. |
As I did mention, the language strings should of course be created, if someone with more wisdom with their locations and correct placements can add them to the correct language file for this PR, it would be appreciated, as I'm not familiar with the conventions you guys use there. |
|
Thank you. |
Since the navigation for multi-page articles (plugins/content/pagebreak.pagebreak.php) can't be template-overridden (unlike the article navigation in pagenavigation.php, which can), we could make some basic improvements to it in the core. This is what I did for my site and I think could be beneficial in general:
Add CSS classes to the prev/next links, so they can be stylized via CSS. Currently they have no class.
When we are on the first page, there is little point in showing a blank unclickable "prev" link. Same thing for when we are on the last page and the "next link", I think they shouldn't be shown at all.
Technically, it would be ideal to use (create) a different language string for these next/prev links, as they are not the generic next/prev article links, but they represent next page/previous page. By having a different language string (like JPREV_PAGE and JNEXT_PAGE) we can individually value these as "PREV PAGE" and "NEXT PAGE".
Summary of Changes
Of course, if we do this, an additional language string with "PREV PAGE" and "NEXT PAGE" respectively should be created.
This is my first pull request and I had a hard time figuring out how to set it up so excuse any possible mistake.