Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0 ]Installation password bug #15038

Closed
wants to merge 1 commit into from

Conversation

NunoLopesPT
Copy link
Contributor

@NunoLopesPT NunoLopesPT commented Apr 1, 2017

Pull Request for Issue # .

Summary of Changes

Remove an attribute that was causing a bug when typing password on installation

Testing Instructions

Write till 3 characters on the password filed

Expected result

No "empty" message

Actual result

Actually this is showing that the field is empty when its not

@NunoLopesPT NunoLopesPT changed the base branch from staging to 4.0-dev April 1, 2017 01:40
@jreys
Copy link
Contributor

jreys commented Apr 1, 2017

Instead of removing the message you should actually change the old one to something like "Field value is too short"

@C-Lodder
Copy link
Member

C-Lodder commented Apr 1, 2017

Could you please add [4.0] to the title of the PR, so people can easily see which branch it's for

@brianteeman brianteeman changed the title Installation password bug [4.0]Installation password bug Apr 1, 2017
@brianteeman
Copy link
Contributor

Updated title as requested

@joomla-cms-bot joomla-cms-bot changed the title [4.0]Installation password bug [4.0 ]Installation password bug Apr 1, 2017
@NunoLopesPT
Copy link
Contributor Author

I think this is showing All checks failed because by mistake I made this PR to staging branch and then changed to the current one (4.0-dev), no?

@dgrammatiko
Copy link
Contributor

@NunoLopes96 this is not the right approach, please don't merge this!!!

@brianteeman brianteeman modified the milestone: Joomla 4.0 Jun 8, 2017
@brianteeman
Copy link
Contributor

I am closing this as it is clearly not correct

@NunoLopesPT NunoLopesPT deleted the InstallPasswordBug branch August 22, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants