Fix Undefined index: assetgroup_id & language_id and batch move to child of self error message #15152
Conversation
…string by casting instead of calling getMessage on exception object. Batch move error fix as in joomla#15132
|
I have tested this item ✅ successfully on 498eeff This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15152. |
| @@ -255,7 +255,7 @@ public function batch($commands, $pks, $contexts) | |||
|
|
|||
| foreach ($this->batch_commands as $identifier => $command) | |||
| { | |||
| if (strlen($commands[$identifier]) > 0) | |||
| if (!empty($commands[$identifier])) | |||
There was a problem hiding this comment.
Are you sure? If yes, then we could reduce code and remove definitions of protected $batch_commands in models: com_banners/.../banner.php, com_fields/.../field.php, com_fields/.../group.php, com_menus/.../item.php, com_modules/.../module.php, com_tags/../tag.php
There was a problem hiding this comment.
@bertmert You're right!
There was a problem hiding this comment.
Thanks. I'll keep in mind to send a PR then that removes these definitions.
There was a problem hiding this comment.
This prevents trigger of an unsupported command for the specific model just by passing the matching parameter in the request. Hence listing the supported values in each model is a good idea, imo.
|
is this PR ready for test? |
|
I have tested this item ✅ successfully on 498eeff This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15152. |
|
RTC after two successful tests. |
Pull Request for Issue #15132.
Summary of Changes
Fix move to child error message.
JObjectwas converting exception to string by casting instead of callinggetMessageonExceptionobject.Fixed batch move error message when moving to child of self in menu manager, fields, categories.
Testing Instructions
See #15132
Documentation Changes Required
None