New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Replace js alerts for joomla alerts #15315
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2df5ec7
replace js alerts for joomla alerts
NunoLopesPT de953ff
Changed JText to see if pass Travis
NunoLopesPT 56c0dd0
Reverted changes
NunoLopesPT 6ae685f
fixed travis error
NunoLopesPT 368f9f1
Merge branch 'replaceJSalerts' of https://github.com/NunoLopes96/joom…
NunoLopesPT ef1d631
Travis error
NunoLopesPT c90bfed
\n and \t are not working in , trying different ways
NunoLopesPT 746f8d1
Codestyle
NunoLopesPT 64b6b80
Removed JText::_, Added JText::script, no need now to use <h4>Warning…
NunoLopesPT e6af6dc
replaced JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST
NunoLopesPT 3c2d421
Travis error
NunoLopesPT 76740e0
Replace line in lang
NunoLopesPT 5854293
Remove unneeded variable
wilsonge File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be here