You have tried to upload file(s) that are not safe.

[zero-24]

Pull Request for Issue #8903

Summary of Changes

If there is no info returned from JInputFiles get() you have tryed to upload unsave content. -> Tell that to the user.

Testing Instructions

Try to upload a zip file containing php scripts e.g. a extension using com_media.

Expected result

Error message: You have tryed to upload a save file that is not save.

Actual result

No message

Documentation Changes Required

None.

[julienV]

should be 'you tried to...'

[brianteeman]

correct it should be tried

[zero-24]

Thanks fixed with the last commit.

[julienV]

this only fixes the issue for upload done in com_media, but not from other code using jinputfile get function... I still think raising an exception there is necessary, and here you should catch it instead of testing for empty $files

[zero-24]

i have just replyed to the other issue please open a PR with that exeption against the 4.0 branch and test the temp fix here. Thanks

[ghost]

@zero-24 can you say a extension using com_media to test correctly?

[zero-24]

You can try to upload any extension (zip file) using com_media. I have tried a custom extension one.

[ghost]

@zero-24 can you give me a Name for an Extension using com_media?

[zero-24]

Ah than you missunderstood that. You should just try to upload a zip file containing a extension. (or any other PHP code)

Like the weblinks package. As this is marked as unsafe file. The extension itself do not matter :)

[ghost]

I have tested this item ✅ successfully on 1bc78ff

Tried upload com_patchtester.zip in "Media", got expected Error Message.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15466.}

[ghost]

Please reassign Milestone 3.7.1. Was removed cause set "Easy Test" on "Yes".

[Quy]

How about This file(s) is unsafe to upload. to be consistent with sentence structure as the following line?

[zero-24]

Would be great to get some testers here? ;)

[wojsmol]

@zero-24 I will test this, give me one hour :)

[wojsmol]

I have tested this item ✅ successfully on 9304662

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15466.}

[zero-24]

Thanks.