-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tags] Respect the current user access levels #15467
Conversation
This needs to be tested to ensure there is no data loss during the save processes if a user with a higher level access sets some tags, then a user with lower level access edits the item later. |
hmm correct this is a issue how do you suggest to fix this? Doing some expensive save the current value compare that with the new value and ignore changes which the current user has no permissions to change? In the content save method? |
As such a handling needs to be implemented in any extension that has tags support implemented |
I have tested this item ✅ successfully on dd56c17 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467. |
I have tested this item ✅ successfully on dd56c17 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467. |
RTC after two successful tests. |
@franz-wohlkoenig I mean:
So this means:
|
@zero-24 thanks for Explination, will test Tomorrow. |
Ah ok I see. Then Ill test that as well as soon as I can. |
I have tested this item 🔴 unsuccessfully on dd56c17 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467. |
I have tested this item 🔴 unsuccessfully on dd56c17 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467. |
Closing here based on the unsuccessfull tests above. |
Pull Request for Issue #8569
Summary of Changes
Respect the access levels
Testing Instructions
Create a TAG in the Tags component, set the access to Super Users
Login in as a manager or another user not in Super User group
Create new article and select Tags
Expected result
The tag with view access Super Users is not visible (for non superusers)
Actual result
All tags visible, regardless of access set in Tag component (for non superusers)
Documentation Changes Required
None