Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags] Respect the current user access levels #15467

Closed
wants to merge 1 commit into from

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Apr 21, 2017

Pull Request for Issue #8569

Summary of Changes

Respect the access levels

Testing Instructions

Create a TAG in the Tags component, set the access to Super Users
Login in as a manager or another user not in Super User group
Create new article and select Tags

Expected result

The tag with view access Super Users is not visible (for non superusers)

Actual result

All tags visible, regardless of access set in Tag component (for non superusers)

Documentation Changes Required

None

@mbabker
Copy link
Contributor

mbabker commented Apr 21, 2017

This needs to be tested to ensure there is no data loss during the save processes if a user with a higher level access sets some tags, then a user with lower level access edits the item later.

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 21, 2017

hmm correct this is a issue how do you suggest to fix this? Doing some expensive save the current value compare that with the new value and ignore changes which the current user has no permissions to change?

In the content save method?

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 21, 2017

As such a handling needs to be implemented in any extension that has tags support implemented

@ghost
Copy link

ghost commented Apr 22, 2017

I have tested this item ✅ successfully on dd56c17

Tag havin Access "Super Users" isn't shown in Article-View if logged-in as "Manager" (not Member of User-Group "Super Users").


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.1 milestone Apr 22, 2017
@rjcf18
Copy link
Contributor

rjcf18 commented Apr 25, 2017

I have tested this item ✅ successfully on dd56c17

Created a new tag with access to Super Users, created a manager user and logged in as that user, created a new article, checked the tags and the tag with view access Super Users was not visible as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467.

@ghost
Copy link

ghost commented Apr 25, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 25, 2017
@zero-24
Copy link
Contributor Author

zero-24 commented Apr 25, 2017

@franz-wohlkoenig @rjcf18 did you also check the issue that @mbabker noted?

@rdeutz rdeutz added this to the Joomla 3.7.1 milestone Apr 25, 2017
@ghost
Copy link

ghost commented May 1, 2017

@zero-24 need to test Issue @mbabker noted: do you mean "there is no data loss during the save processes" tags or i.E. Fulltext, Publishes Date, ...?

@zero-24
Copy link
Contributor Author

zero-24 commented May 1, 2017

@franz-wohlkoenig

I mean:

This needs to be tested to ensure there is no data loss during the save processes if a user with a higher level access sets some tags, then a user with lower level access edits the item later.

So this means:

  • Super User adds a article with super user tags (tags who can only be added by a super user)
  • admin (that can't access that superuser tags) open and save the article.
  • The Super User checks if the "superuser tags" are gone or not.

@ghost
Copy link

ghost commented May 1, 2017

@zero-24 thanks for Explination, will test Tomorrow.

@rjcf18
Copy link
Contributor

rjcf18 commented May 1, 2017

Ah ok I see. Then Ill test that as well as soon as I can.

@rdeutz rdeutz modified the milestones: Joomla 3.7.2, Joomla 3.7.1 May 1, 2017
@ghost
Copy link

ghost commented May 2, 2017

I have tested this item 🔴 unsuccessfully on dd56c17

Super-User-Tag is gone after a Non-Super-User saved an Article having a Super-User-Tag.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467.

@rjcf18
Copy link
Contributor

rjcf18 commented May 2, 2017

I have tested this item 🔴 unsuccessfully on dd56c17

@zero-24 I've verified and after opening and saving an article with a super user tag as a non super user the tag was indeed gone from the article when it was reopened later.
deepinscreenshot20170502143933


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15467.

@zero-24 zero-24 removed this from the Joomla 3.7.2 milestone May 2, 2017
@rdeutz rdeutz removed the RTC This Pull Request is Ready To Commit label May 4, 2017
@zero-24
Copy link
Contributor Author

zero-24 commented May 21, 2017

Closing here based on the unsuccessfull tests above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants