Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum width of td fields for calendar field #15928

Closed
wants to merge 1 commit into from

Conversation

johnkrzywanek
Copy link

@johnkrzywanek johnkrzywanek commented May 10, 2017

Summary of Changes

In some cases lack of set width for td element and 100% width for td with 'today' class breaks the table.

Set minimum width of td fields to 38px and removed 100% from td with 'today' class.

Testing Instructions

You can see the problem for example on Aura template from Themeforest (https://themeforest.net/item/aura-responsive-multipurpose-joomla-template/11509513), here is a screenshot from that: http://imgur.com/WOSz6FP

Expected result

All td elements in table should have the same width.

Actual result

Before the fix the td element with 'today' class tried to take as much space as possible, see here: http://imgur.com/a/T6Jgf

@johnkrzywanek johnkrzywanek changed the title Set minimum width of td fields Set minimum width of td fields for calendar field May 10, 2017
@brianteeman
Copy link
Contributor

doesnt the rtl css file need updating as well?

@degobbis
Copy link
Contributor

@dmr86 can you please add your changes to the calendar-rtl.css file too?

@Quy
Copy link
Contributor

Quy commented Mar 19, 2018

Closing in favor of #19944


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15928.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/15928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants