New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Revert switcher #15946
[4.0] Revert switcher #15946
Conversation
…work with fieldsets for some reason
@Bakual you need to remove switcher from grunt-settings.yaml and remove the related lines from Gruntfile.js.
Just rename the Anyways I'm not in favour of removing the switcher but I'm ok with reverting the xml changes. By the way switcher can still be done with the original xml structure... |
I think this should be a temporary fix until we can restore the fieldset tag.
@dgt41 Afaik it wasn't a file pulled in using Grunt, it something done ourself. I did have a look now at those grunt files and couldn't find anything related to switcher.js. If I missed something, feel free to point me to it.
I did the changes to the XML, JS and CSS in separate commits for that reason so it would be easy to take only parts of this PR. |
My 2c i am not convinced that a switcher is suitable for a desktop application - so at this time I would agree to removing it and reverting back as here. It can be looked at again in the future |
So this decision was actually driven based on us having some conflicts between CSS frameworks, but we ended up pulling out all of the switcher based checkboxes in the frontend of an app we're building right now in favor of "plain" checkboxes. I realize our switchers are primarily radio based, but the same general concept applies. |
Got the |
At this time I am closing this PR. We need to let the J4 guys deliver and alpha with this and then we can of course review it then when a wider audience have seen it. Change is always disturbing but we have to be brave and try things. |
Pull Request for Issue #15391 .
Summary of Changes
Testing Instructions
Open various settings page. Most occurances of those radio elements are typical in component settings.
Expected result
Have an intuitive toggle button
Actual result
Have an unintuitive switcher thing with inverted option order and unclear states
Documentation Changes Required
None
Known issue
Maybe someone can help me here:
The
btn-group
doesn't work with the<fieldset>
tag. I changed the tag generated in the radio JLayout to<div>
and it works fine. This may be a bug in BS4, I wasn't able to figure out where the difference comes from.