Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid conflict between JQTooltip in the same DOM as a BSTooltip #15951

Merged
merged 3 commits into from Dec 23, 2017
Merged

Avoid conflict between JQTooltip in the same DOM as a BSTooltip #15951

merged 3 commits into from Dec 23, 2017

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented May 10, 2017

Pull Request for Issue Closes #15896.

Summary of Changes

Allow JQTooltip in the same DOM as a BSTooltip without JS errors when destorying tooltips in mediafield javascript

Testing Instructions

To setup:
Add this jQueryUI code to your /administrator/templates/isis/index.php before

<script src="https://code.jquery.com/ui/1.12.0/jquery-ui.min.js" integrity="sha256eGE6blurk5sHj+rmkfsGYeKyZx3M4bG+ZlFyA7Kns7E=" crossorigin="anonymous"></script>

Replicate the error in the JS console

screen shot 2017-05-10 at 20 50 07

To Test:
Apply PR (leaving jQueryUI in isis/index.php)
See Error disappears
Check this works with debug OFF and debug ON in Joomla Config. (one uses minified JS and one doesnt)

Expected result

No console errors

Documentation Changes Required

None

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 8de0ff4

replicated the error and confirmed the fix


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 8de0ff4

correction - the fix does remove the js error in the console but it still leaves other broken behaviour


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.

@brianteeman
Copy link
Contributor

with the PR and jquery-ui loaded
phil

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@Yves-K
Copy link

Yves-K commented May 25, 2017

Hello Phil,
Successfully tested.
Thank you very much for making it done (i really did not know how to create a pull request...)

@Yves-K
Copy link

Yves-K commented May 25, 2017

I have tested this item ✅ successfully on 8de0ff4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.

@Yves-K
Copy link

Yves-K commented May 25, 2017

Hi @hikashop-nicolas, might solve #14259.
Can you test too ?

@hikashop-nicolas
Copy link
Contributor

The issue is still there when you edit a HikaShop products listing menu item with HikaShop below the 3.0.1, even with that patch.
We modified the way we handle the jquery-ui on our end in the 3.0.1 version of HikaShop to circumvent the problem altogether.

@jaimestuardo
Copy link

This worked correctly in my Joomla 3.8.1. I am wondering why this correction is not included in the official release.

@ghost
Copy link

ghost commented Oct 5, 2017

@jaimestuardo we need 2 successfully Tests before a Maintainer can decide if its gonna be merged, so please mark your Test as successfully:

  • Please open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"

@jaimestuardo
Copy link

I have tested this item ✅ successfully on 5744988


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.

@ghost
Copy link

ghost commented Oct 5, 2017

@Yves-K can you please retest?

@Quy
Copy link
Contributor

Quy commented Oct 5, 2017

Fix whitespace. Use tabs.

@ghost
Copy link

ghost commented Oct 26, 2017

@brianteeman can you please retest?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.

@fancyFranci
Copy link
Contributor

I have tested this item ✅ successfully on 5744988

It works and avoids the error message with and without debug mode.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.

@ghost
Copy link

ghost commented Dec 21, 2017

Ready to Commit after two successful tests.

Thanks for Tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 21, 2017
@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 23, 2017
@mbabker mbabker merged commit d76a5c5 into joomla:staging Dec 23, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 23, 2017
photodude pushed a commit to photodude/joomla-cms that referenced this pull request Dec 25, 2017
…la#15951)

* Avoid conflict between JQTooltip in the same DOM as a BSTooltip

* Fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants