New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid conflict between JQTooltip in the same DOM as a BSTooltip #15951
Conversation
I have tested this item ✅ successfully on 8de0ff4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951. |
I have tested this item 🔴 unsuccessfully on 8de0ff4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Hello Phil, |
I have tested this item ✅ successfully on 8de0ff4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951. |
Hi @hikashop-nicolas, might solve #14259. |
The issue is still there when you edit a HikaShop products listing menu item with HikaShop below the 3.0.1, even with that patch. |
This worked correctly in my Joomla 3.8.1. I am wondering why this correction is not included in the official release. |
@jaimestuardo we need 2 successfully Tests before a Maintainer can decide if its gonna be merged, so please mark your Test as successfully:
|
I have tested this item ✅ successfully on 5744988 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951. |
@Yves-K can you please retest? |
Fix whitespace. Use tabs. |
@brianteeman can you please retest? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951. |
I have tested this item ✅ successfully on 5744988 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951. |
Ready to Commit after two successful tests. Thanks for Tests. |
…la#15951) * Avoid conflict between JQTooltip in the same DOM as a BSTooltip * Fix code style
Pull Request for Issue Closes #15896.
Summary of Changes
Allow JQTooltip in the same DOM as a BSTooltip without JS errors when destorying tooltips in mediafield javascript
Testing Instructions
To setup:
Add this jQueryUI code to your /administrator/templates/isis/index.php before
Replicate the error in the JS console
To Test:
Apply PR (leaving jQueryUI in isis/index.php)
See Error disappears
Check this works with debug OFF and debug ON in Joomla Config. (one uses minified JS and one doesnt)
Expected result
No console errors
Documentation Changes Required
None