Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for filter input #16201

Merged
merged 2 commits into from May 24, 2017
Merged

Conversation

csthomas
Copy link
Contributor

@csthomas csthomas commented May 22, 2017

Pull Request for Issue #16112

Summary of Changes

Joomla does not have to use multibyte mb_ or utf8_ functions to parsing UTF-8 input.

Testing Instructions

Expected result

All works as expected and parsing is faster.

Actual result

Parsing is slow.

Documentation Changes Required

No

@lynnfredricks
Copy link

#16112
@franz-wohlkoenig I just tested with 3.7.2 and execution time is not improved enough. Error has changed through:
/libraries/vendor/joomla/string/src/phputf8/mbstring/core.php on line 94

@csthomas
Copy link
Contributor Author

@lynnfredricks There is some misunderstanding. You said that you tested J3.7.2 and it is still slow, but IMO you have not tested it with current patch.

TEST INSTRUCTION

To test with current patch you can do:

  1. Create a copy of your original file in libraries/joomla/filter/input.php

  2. Download a file from https://raw.githubusercontent.com/csthomas/joomla-cms/1532e1156e6aba108af4fe649e6ffece4b4a10f8/libraries/joomla/filter/input.php

  3. Save downloaded file to your joomla folder, by replacing libraries/joomla/filter/input.php

  4. Now you can start the tests.

  5. After tests you can revert changes

The other way is to install fresh joomla from my branch:

  1. Download and install Joomla from https://github.com/csthomas/joomla-cms/archive/fixfilter.zip
  2. Add article and test.

Or

  1. To your current installed joomla 3.7.2 install component com_patchtester from:
    https://github.com/joomla-extensions/patchtester/releases/tag/2.0.1
  2. Apply patch with the same title as this PR or search by id 16201
  3. After this patch will be applied then you can start the tests.
  4. After tests you can revert changes in the component and uninstall com_patchtester

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 1532e11

This is spectacular!

Logged as a manager with the said article to which I added some utf8 in pagebreak.

Before patch: 270sec

After patch: between 15 and 20 sec depending if reload is included!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16201.

@AlexRed
Copy link
Contributor

AlexRed commented May 24, 2017

I have tested this item ✅ successfully on 1532e11

Patch ok for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16201.

@ghost
Copy link

ghost commented May 24, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 24, 2017
@infograf768 infograf768 added this to the Joomla 3.7.3 milestone May 24, 2017
@lynnfredricks
Copy link

@csthomas Thank you for the instructions and help! I can confirm that I was able to both duplicate the existing article and also update / replace the text of the existing long article.

@rdeutz rdeutz merged commit 495dcc7 into joomla:staging May 24, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging Unit/System Tests and removed RTC This Pull Request is Ready To Commit labels May 24, 2017
@csthomas csthomas deleted the fixfilter branch May 24, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants