Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the JLogEntry class #16342

Merged
merged 1 commit into from May 29, 2017
Merged

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 29, 2017

Pull Request for Issue #16315 and #16311.

Summary of Changes

class_alias is actually not loading the alias class. Additionally when you have typed function arguments and instanceof calls, the class is also not loaded. Because the logger is called very early it can lead to a situation that the class JLogEntryis not loaded but a logger which is not namespaced requires still JLogEntry and then we get an error like:
Argument 1 passed to PlgSystemDebug::logger() must be an instance of JLogEntry, instance of Joomla\CMS\Log\LogEntry given

This pr is a workaround to use JLogEntryinstead of the namespaced class.

Testing Instructions

  • Enable debugging in Joomla configuration
  • Enable in the debug plugin Logging
    image

Expected result

No Error is thrown.

Actual result

Error is thrown.

@wilsonge wilsonge merged commit 12747a6 into joomla:3.8-dev May 29, 2017
@wilsonge wilsonge added this to the Joomla 3.8.0 milestone May 29, 2017
@wilsonge wilsonge deleted the j3/fix/jlogentry-error branch May 29, 2017 17:17
@wilsonge
Copy link
Contributor

This is bullshit. But I dunno what's better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants