Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #16315 and #16311.
Summary of Changes
class_alias
is actually not loading the alias class. Additionally when you have typed function arguments andinstanceof
calls, the class is also not loaded. Because the logger is called very early it can lead to a situation that the classJLogEntry
is not loaded but a logger which is not namespaced requires stillJLogEntry
and then we get an error like:Argument 1 passed to PlgSystemDebug::logger() must be an instance of JLogEntry, instance of Joomla\CMS\Log\LogEntry given
This pr is a workaround to use
JLogEntry
instead of the namespaced class.Testing Instructions
Expected result
No Error is thrown.
Actual result
Error is thrown.