fix populatestate method of category model for com_contact #16482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the user session data for the value of filter-search so pagination always failed to remember the value fixes issue joomla#9273
ghost
mentioned this pull request
|
I have tested this item ✅ successfully on 08c483c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16482. |
Quy
reviewed
Jun 4, 2017
| @@ -248,7 +248,9 @@ protected function populateState($ordering = null, $direction = null) | |||
| $this->setState('list.start', $limitstart); | |||
|
|
|||
| // Optional filter text | |||
| $this->setState('list.filter', $app->input->getString('filter-search')); | |||
| $itemid =$app->input->get('Itemid', 0, 'int'); | |||
|
I have tested this item ✅ successfully on 80008c5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16482. |
|
@carcam can you please test again? |
|
@franz-wohlkoenig It is not necessary to retest since it was only to add a space. |
joomla-cms-bot
changed the title
|
RTC after two successful tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populatestate method of category model for com_contact was not using the user session data for the value of filter-search so pagination always failed to remember the value
fixes issue #9273
Summary of Changes
Use $app->getUserStateFromRequest instead of $app->input->get to fetch the filter value