Fix custom fields without a fieldgroup not being displayed #16705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 147cc42 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705. |
Quy
reviewed
Jun 15, 2017
| @@ -408,8 +408,17 @@ function categoryHasChanged(element) { | |||
| $model = JModelLegacy::getInstance('Groups', 'FieldsModel', array('ignore_request' => true)); | |||
| $model->setState('filter.context', $context); | |||
|
|
|||
| // $model->getItems() would only return existant groups, but we also | |||
| // have the 'default' group with id 0 with isn't existant in the database, | |||
There was a problem hiding this comment.
Change to which is not in the database.
Quy
reviewed
Jun 15, 2017
| @@ -408,8 +408,17 @@ function categoryHasChanged(element) { | |||
| $model = JModelLegacy::getInstance('Groups', 'FieldsModel', array('ignore_request' => true)); | |||
| $model->setState('filter.context', $context); | |||
|
|
|||
| // $model->getItems() would only return existant groups, but we also | |||
|
I have tested this item ✅ successfully on 1bf2794 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705. |
1 similar comment
|
I have tested this item ✅ successfully on 1bf2794 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 193e39c introduced the usage of FieldsModelGroups::getItems() when getting the fieldgroups (and hence their fieldset in the backend editing layout) for the fields.
Unfortunately, that commit also introduced a bug, by which custom fields without a field group won't get displayed anymore. This PR fixes this issue.
This should get into the 3.7.3 release, as else the functionality of custom fields is broken.