New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom fields without a fieldgroup not being displayed #16705

Merged
merged 3 commits into from Jun 15, 2017

Conversation

Projects
None yet
7 participants
@continga
Contributor

continga commented Jun 15, 2017

Commit 193e39c introduced the usage of FieldsModelGroups::getItems() when getting the fieldgroups (and hence their fieldset in the backend editing layout) for the fields.

Unfortunately, that commit also introduced a bug, by which custom fields without a field group won't get displayed anymore. This PR fixes this issue.

This should get into the 3.7.3 release, as else the functionality of custom fields is broken.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Jun 15, 2017

Member

I have tested this item successfully on 147cc42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705.

Member

laoneo commented Jun 15, 2017

I have tested this item successfully on 147cc42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705.

Show outdated Hide outdated administrator/components/com_fields/helpers/fields.php
@@ -408,8 +408,17 @@ function categoryHasChanged(element) {
$model = JModelLegacy::getInstance('Groups', 'FieldsModel', array('ignore_request' => true));
$model->setState('filter.context', $context);
// $model->getItems() would only return existant groups, but we also
// have the 'default' group with id 0 with isn't existant in the database,

This comment has been minimized.

@Quy

Quy Jun 15, 2017

Contributor

Change to which is not in the database.

@Quy

Quy Jun 15, 2017

Contributor

Change to which is not in the database.

Show outdated Hide outdated administrator/components/com_fields/helpers/fields.php
@@ -408,8 +408,17 @@ function categoryHasChanged(element) {
$model = JModelLegacy::getInstance('Groups', 'FieldsModel', array('ignore_request' => true));
$model->setState('filter.context', $context);
// $model->getItems() would only return existant groups, but we also

This comment has been minimized.

@Quy

Quy Jun 15, 2017

Contributor

Change to existing.

@Quy

Quy Jun 15, 2017

Contributor

Change to existing.

@Quy

This comment has been minimized.

Show comment
Hide comment
@Quy

Quy Jun 15, 2017

Contributor

I have tested this item successfully on 1bf2794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705.

Contributor

Quy commented Jun 15, 2017

I have tested this item successfully on 1bf2794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705.

@laoneo

This comment has been minimized.

Show comment
Hide comment
@laoneo

laoneo Jun 15, 2017

Member

I have tested this item successfully on 1bf2794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705.

Member

laoneo commented Jun 15, 2017

I have tested this item successfully on 1bf2794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16705.

@zero-24 zero-24 added this to the Joomla 3.7.3 milestone Jun 15, 2017

@rdeutz rdeutz merged commit 250fc2a into joomla:staging Jun 15, 2017

5 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@continga continga deleted the continga:fix-subfield-groups branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment