[4.0] Move toolbar button ID'd to buttons themselves

[C-Lodder]

This PR fixes the issue mentioned here #16763

I've reverted the previous PR (#16749) I did that adds a div wrapper for each button and the ID is now added on the button itself.

Both list and edit views seem to work.

@infograf768 - You mentioned something about com_associations using JS to target these ID's. Would you mind testing please and let me know.

[Bakual]

I get Notice: Undefined index: id in ...\layouts\joomla\toolbar\versions.php on line 31

[C-Lodder]

@Bakual - oops, fixed.

[Bakual]

Buttons in com_content are now fixed.
Com_associations seems to work. The toolbar buttons disappear as soon as you have selected a type and language. Same as in J3.

[C-Lodder]

Not sure I can replicate this. Would you be able to capture a GIF for me to see?

[Bakual]

My comment was unclear. Everything works from what I see 👍

[C-Lodder]

ah fair enough, thanks for testing

[ghost]

I have tested this item ✅ successfully on 38c407f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16779.}

[ghost]

@Bakual can i alter your Test as successfully?

[Bakual]

@franz-wohlkoenig Didi it myself now, but thanks for the reminder 👍

[ghost]

RTC after two successful tests.

[yvesh]

@wilsonge can you merge that asap, as it blocks some GSoC projects :-)

[bembelimen]

If I open the save button now (to show the other save options), the button "jumps" (enlarge a bit), was this also before this patch or was this introduced via this patch?

[Bakual]

Doesn't do that for me, using Chrome.
If it does for you, can you open a new issue with browser versions and the like?

[C-Lodder]

@bembelimen what browser are you experiencing that on? Try clearing your cache if you havent already