Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiddenFieldsets & configFieldsets needs to be defined #16856

Merged
merged 31 commits into from
May 12, 2018
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c9419cf
hiddenFieldsets & configFieldsets needs to be defined
zero-24 Jun 24, 2017
ba91e12
use getter
zero-24 Jun 24, 2017
837bf51
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Jul 11, 2017
f62e1db
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Jul 12, 2017
64cc0d0
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Jul 13, 2017
e0aaeec
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Jul 17, 2017
2f005a1
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Jul 18, 2017
0d0abbe
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Jul 24, 2017
2764372
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 13, 2017
4faa343
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 14, 2017
a6e56cd
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 14, 2017
85cd54a
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 15, 2017
3ef68b2
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 16, 2017
01ad263
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 17, 2017
e2dedd5
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 17, 2017
3447509
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 18, 2017
94a6474
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 20, 2017
211c147
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 25, 2017
2cc345d
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 29, 2017
14b9a7e
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 29, 2017
410192a
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 30, 2017
31880c3
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Aug 31, 2017
948e7ec
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 2, 2017
d13e27a
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 3, 2017
02e6a14
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 5, 2017
f218d92
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 9, 2017
54f1f2f
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 11, 2017
604f023
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 14, 2017
56a4e35
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 15, 2017
1e8529d
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 16, 2017
eb60cb5
Merge branch 'staging' of github.com:joomla/joomla-cms into $hiddenFi…
zero-24 Sep 29, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 4 additions & 10 deletions layouts/joomla/edit/params.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,11 @@
$extraFields = $displayData->get('extra_fields') ?: array();
$tabName = $displayData->get('tab_name') ?: 'myTab';

if (!empty($displayData->hiddenFieldsets))
{
// These are required to preserve data on save when fields are not displayed.
$hiddenFieldsets = $displayData->hiddenFieldsets ?: array();
}
// These are required to preserve data on save when fields are not displayed.
$hiddenFieldsets = $displayData->get('hiddenFieldsets') ?: array();

if (!empty($displayData->configFieldsets))
{
// These are required to configure showing and hiding fields in the editor.
$configFieldsets = $displayData->configFieldsets ?: array();
}
// These are required to configure showing and hiding fields in the editor.
$configFieldsets = $displayData->get('configFieldsets') ?: array();

// Handle the hidden fieldsets when show_options is set false
if (!$displayData->get('show_options', 1))
Expand Down