Regression: Multilingual com_tags getting wrong language cookie

[infograf768]

Pull Request for Issue #17053

Summary of Changes

JHelper and JHelperContent do not take into account both ways of setting a lang cookie by the languagefilter plugin.
If the setting is to a year, the cookie is stored separately.
If the setting is set to Session, it is set in the session cookie (this was introduced in #12306 )

com_tags (and possibly some 3rd party extensions) use these classes to display the tags when the parameter is set to use current_language

Testing Instructions

See details in #17053

Set the languagefilter Cookie lifetime to Session:

for the following demo, I have created a single tag Mystag.
I have assigned it to the article Another article french tagged to French (fr-FR)
Also to to the article newarticle english tagged to English (en-GB)
And to the article myarticle tagged to ALL content languages.
Create a Tagged Items menu item to display that single tag and make sure Language Filter is set to Current

When switching languages, that menu item will now correctly display 2 articles, one set to the Content Language in use, the other set to ALL content languages.

@mino182
@tonypartridge

[infograf768]

Another solution (which would not touch at the helpers) is to use specifically for com_tags, every time we have a current_language conditional (therefore including the tags modules), JFactory: :getApplication()->getLanguage()->getTag(); instead of JHelperContent::getCurrentLanguage()

@mbabker
@rdeutz

What do you think?

[zero-24]

New Registry + namespace load here please :)

[alikon]

this pr is in the 3.7.x branch do we need to namespace in 3.7.x too ???

[mbabker]

Registry has been namespaced since 3.4.

[infograf768]

me not know how to, but if I am asked to use the other solution, this would anyway be obsolete.
@mbabker please let me know your thought

[mbabker]

For the namespacing thing, look at any other file which has a use Joomla\Registry\Registry; statement, copy that into the same place, and change JRegistry to Registry.

[zero-24]

Same here

[mbabker]

I honestly don't know what the purpose of JHelperContent::getCurrentLanguage() is (remember I really don't do multilingual stuff and the sites that I have it on it's all managed by others). The one thing I think seems a little off though is https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/helper/content.php#L159 using the default configured language for the site versus using the active language from JFactory.

[infograf768]

Namespacing done.

[infograf768]

The one thing I think seems a little off though is https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/helper/content.php#L159 using the default configured language for the site versus using the active language from JFactory.

As this is an urgent PR for 3.7.4, I guess it is better, in case we keep modifying the helpers, to leave the rest of the code alone.

changes done

[AlexRed]

I have tested this item ✅ successfully on 3a4ad0a

Patch ok for me

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17084.}

[zero-24]

I have tested this item ✅ successfully on 3a4ad0a

😄

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17084.}

[zero-24]

Thanks JM

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17084.}