Add the checked attribute for the bcc field #17336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 49bedc8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17336. |
|
please reassign Milestone 3.8.0 |
|
Doh I looked at this and didnt realise there was a checked value needed for a checkbox as it is nt mentioned in the documentation https://docs.joomla.org/Checkbox_form_field_type. Does it therefore still need the default value being set as well? |
|
I have just looked at the code and found the checked option. IMO we can change that in the doku than. |
|
or we have a very long stndig issue and need to fix the default value too. |
|
but that would be out of scope for that PR. IMO |
|
I have tested this item ✅ successfully on 49bedc8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17336. |
|
RTC after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
Aug 9, 2017
* staging: (148 commits) Correcting non-escaped double quotes in en-GB.plg_sampledata_testing.ini (joomla#17455) Correct namespace reference (Fix joomla#17448) Correcting Jalali/Persian calendar popup (joomla#17432) Adding russian calendar language file (joomla#17443) Reset for dev Prepare 3.8 Beta release Fix covers tags Fix file paths Move library files to just libraries/src as it should be (joomla#17441) Add a default empty array for the session queue (joomla#16943) [3.8] Restructure version constants (joomla#16169) Adjusting copyright and versions and two remaining "sampledata" (joomla#17435) PHP 7.2 has branched, update Travis config to reflect PHP 7.2 count warning (joomla#16840) Enforce array for subform values (joomla#16733) System URL menu link (joomla#17419) Don't use array merge here. (joomla#17391) add the checked attribute (joomla#17336) [RFC] Mod sample data (joomla#7680) Rename Page to Menu Item (joomla#17409) ...
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
Aug 9, 2017
* staging: (148 commits) Correcting non-escaped double quotes in en-GB.plg_sampledata_testing.ini (joomla#17455) Correct namespace reference (Fix joomla#17448) Correcting Jalali/Persian calendar popup (joomla#17432) Adding russian calendar language file (joomla#17443) Reset for dev Prepare 3.8 Beta release Fix covers tags Fix file paths Move library files to just libraries/src as it should be (joomla#17441) Add a default empty array for the session queue (joomla#16943) [3.8] Restructure version constants (joomla#16169) Adjusting copyright and versions and two remaining "sampledata" (joomla#17435) PHP 7.2 has branched, update Travis config to reflect PHP 7.2 count warning (joomla#16840) Enforce array for subform values (joomla#16733) System URL menu link (joomla#17419) Don't use array merge here. (joomla#17391) add the checked attribute (joomla#17336) [RFC] Mod sample data (joomla#7680) Rename Page to Menu Item (joomla#17409) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #17223
Summary of Changes
Add the checked attribute for the bcc field
Testing Instructions
Pre patch the
send bccis not checked by defaultafter patch it is
Expected result
Actual result
Documentation Changes Required
None