Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Bump to PHP 7 minimum #17548

Merged
merged 1 commit into from
Aug 18, 2017
Merged

[4.0] Bump to PHP 7 minimum #17548

merged 1 commit into from
Aug 18, 2017

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Aug 15, 2017

Summary of Changes

Bump 4.0 to PHP 7 per yesterday's announcement

Documentation Changes Required

Add the new minimum to the B/C page

@zero-24
Copy link
Contributor

zero-24 commented Aug 15, 2017

@mbabker
Copy link
Contributor Author

mbabker commented Aug 15, 2017

FWIW the Travis failure exists in the base branch too. So the only thing that should be stopping this for the moment is making sure I didn't completely destroy the AppVeyor config.

@wilsonge
Copy link
Contributor

Holding off on merging this just now until I've finished my round of conflicts i'm about 2/3 of the way through

@zero-24
Copy link
Contributor

zero-24 commented Aug 15, 2017

FWIW the Travis failure exists in the base branch too. So the only thing that should be stopping this for the moment is making sure I didn't completely destroy the AppVeyor config.

see here for the travis issue: #17550

@zero-24
Copy link
Contributor

zero-24 commented Aug 16, 2017

Given that the travis error is a different on #17550 I'm not sure what did happen to appveyor here. Do you have a way to restart the build?

@wilsonge wilsonge merged commit 4e88408 into joomla:4.0-dev Aug 18, 2017
@mbabker mbabker deleted the bump-php branch August 18, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants